From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] mmc: atmel-mci: remove __init/__exit attributes
Date: Fri, 28 Nov 2014 14:16:51 +0000 [thread overview]
Message-ID: <20141128141651.GS3836@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1417183686-31481-3-git-send-email-ludovic.desroches@atmel.com>
On Fri, Nov 28, 2014 at 03:08:04PM +0100, Ludovic Desroches wrote:
> Using __init/__exit attributes can cause several breakages so remove
> them.
I've really no idea why people jump overboard with these things - it
seems people go from one extreme to the other (adding lots of __init /
__exit annotations everywhere to removing them all), but:
> @@ -2573,12 +2573,12 @@ static struct platform_driver atmci_driver = {
> },
> };
>
> -static int __init atmci_init(void)
> +static int atmci_init(void)
> {
> return platform_driver_probe(&atmci_driver, atmci_probe);
> }
>
> -static void __exit atmci_exit(void)
> +static void atmci_exit(void)
> {
> platform_driver_unregister(&atmci_driver);
> }
These last two are totally fine to leave there.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-11-28 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 14:08 [PATCH v3 0/4] mmc: atmel-mci: cleanup and probe deferring Ludovic Desroches
2014-11-28 14:08 ` [PATCH v3 1/4] mmc: atmel-mci: remove useless DMA stuff for non-dt devices Ludovic Desroches
2014-11-28 14:08 ` [PATCH v3 2/4] mmc: atmel-mci: remove __init/__exit attributes Ludovic Desroches
2014-11-28 14:16 ` Russell King - ARM Linux [this message]
2014-11-28 14:08 ` [PATCH v3 3/4] mmc: atmel-mci: stop using specific initcall Ludovic Desroches
2014-11-28 14:08 ` [PATCH v3 4/4] mmc: atmel-mci: use probe deferring if dma controller is not ready yet Ludovic Desroches
2014-11-28 14:19 ` Russell King - ARM Linux
2014-11-28 14:35 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128141651.GS3836@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).