linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6: fix bogus use of irq_get_irq_data
Date: Tue, 2 Dec 2014 23:30:37 +0800	[thread overview]
Message-ID: <20141202153036.GQ2411@dragon> (raw)
In-Reply-To: <547DD92B.8090104@arm.com>

On Tue, Dec 02, 2014 at 03:22:19PM +0000, Marc Zyngier wrote:
> On 02/12/14 15:15, Shawn Guo wrote:
> > On Tue, Dec 02, 2014 at 02:53:08PM +0000, Marc Zyngier wrote:
> >> Hi Shawn,
> >>
> >> On 02/12/14 14:48, Shawn Guo wrote:
> >>> On Mon, Dec 01, 2014 at 05:04:03PM +0000, Marc Zyngier wrote:
> >>>> The imx6 PM code seems to be quite creative in its use of irq_data,
> >>>> using something something that is very much a hardware interrupt
> >>>> number where we expect a virtual one.  Yes, it worked so far, but
> >>>> that's only cheer luck, and it will definitely explode in 3.19.
> >>>>
> >>>> Fix it by using a pair of helper functions that deal with the
> >>>> actual hardware.
> >>>>
> >>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> >>>
> >>> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> >>>
> >>> Arnd, Olof,
> >>>
> >>> To avoid a non-booting 3.19-rc1 on i.MX6, please apply it for 3.19-rc1.
> >>
> >> The previous patch (ARM: imx: irq: fix buggy usage of irq_data irq
> >> field) should also be applied (you cannot apply one without the other
> >> anyway).
> > 
> > Marc,
> > 
> > Thanks a lot for the fixes.  To ease arm-soc folks' work, you should
> > probably resend the patches with squashing them into one or having them
> > in a series.
> 
> Sure. Can I put your Acked-by on both patches?

Yes, Marc.

Shawn

      reply	other threads:[~2014-12-02 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 17:04 [PATCH] ARM: imx6: fix bogus use of irq_get_irq_data Marc Zyngier
2014-12-01 17:13 ` Fabio Estevam
2014-12-01 17:15 ` Philipp Zabel
2014-12-01 17:23   ` Marc Zyngier
2014-12-01 17:57 ` Vladimir Murzin
2014-12-01 18:09   ` Marc Zyngier
2014-12-02 14:48 ` Shawn Guo
2014-12-02 14:53   ` Marc Zyngier
2014-12-02 15:15     ` Shawn Guo
2014-12-02 15:22       ` Marc Zyngier
2014-12-02 15:30         ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202153036.GQ2411@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).