From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Tue, 2 Dec 2014 23:30:37 +0800 Subject: [PATCH] ARM: imx6: fix bogus use of irq_get_irq_data In-Reply-To: <547DD92B.8090104@arm.com> References: <1417453443-9179-1-git-send-email-marc.zyngier@arm.com> <20141202144759.GO2411@dragon> <547DD254.4090704@arm.com> <20141202151505.GP2411@dragon> <547DD92B.8090104@arm.com> Message-ID: <20141202153036.GQ2411@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 02, 2014 at 03:22:19PM +0000, Marc Zyngier wrote: > On 02/12/14 15:15, Shawn Guo wrote: > > On Tue, Dec 02, 2014 at 02:53:08PM +0000, Marc Zyngier wrote: > >> Hi Shawn, > >> > >> On 02/12/14 14:48, Shawn Guo wrote: > >>> On Mon, Dec 01, 2014 at 05:04:03PM +0000, Marc Zyngier wrote: > >>>> The imx6 PM code seems to be quite creative in its use of irq_data, > >>>> using something something that is very much a hardware interrupt > >>>> number where we expect a virtual one. Yes, it worked so far, but > >>>> that's only cheer luck, and it will definitely explode in 3.19. > >>>> > >>>> Fix it by using a pair of helper functions that deal with the > >>>> actual hardware. > >>>> > >>>> Signed-off-by: Marc Zyngier > >>> > >>> Acked-by: Shawn Guo > >>> > >>> Arnd, Olof, > >>> > >>> To avoid a non-booting 3.19-rc1 on i.MX6, please apply it for 3.19-rc1. > >> > >> The previous patch (ARM: imx: irq: fix buggy usage of irq_data irq > >> field) should also be applied (you cannot apply one without the other > >> anyway). > > > > Marc, > > > > Thanks a lot for the fixes. To ease arm-soc folks' work, you should > > probably resend the patches with squashing them into one or having them > > in a series. > > Sure. Can I put your Acked-by on both patches? Yes, Marc. Shawn