public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/3] mtd: nand: gpmi: add proper raw access support
Date: Tue, 2 Dec 2014 10:01:01 -0800	[thread overview]
Message-ID: <20141202180101.GK21347@ld-irv-0074> (raw)
In-Reply-To: <20141202092150.738a53bb@bbrezillon>

On Tue, Dec 02, 2014 at 09:21:50AM +0100, Boris Brezillon wrote:
> On Tue, 2 Dec 2014 08:47:43 +0800 Huang Shijie <shijie.huang@intel.com> wrote:
> > On Mon, Dec 01, 2014 at 09:58:58AM +0100, Boris Brezillon wrote:
> > > On Mon, 1 Dec 2014 00:47:09 -0800 Brian Norris <computersforpeace@gmail.com> wrote:
> > > > Also, is it time to yank / fixup some of these comments from
> > > > gpmi-nand.c?
> > > 
> > > I was asking myself the same question...
> > > 
> > > > 
> > > >  ...
> > > >  * FIXME: The following paragraph is incorrect, now that there exist
> > > >  * ecc.read_oob_raw and ecc.write_oob_raw functions.
> > > >  *
> > > >  * Since MTD assumes the OOB is not covered by ECC, there is no pair of
> > > >  * ECC-based/raw functions for reading or or writing the OOB. The fact that the
> > > >  * caller wants an ECC-based or raw view of the page is not propagated down to
> > > >  * this driver.
> > > >  */
> > > 
> > > I guess we can remove them.
> > > Huang can you confirm that the raw access functions introduced in this
> > > series are covering what's described here ?
> > I think we can remove these comments now.
> 
> Brian, do you want me to send this patch or are you taking care of it ?

Go ahead and send a patch.

Brian

      reply	other threads:[~2014-12-02 18:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 18:10 [PATCH v6 0/3] mtd: nand: gpmi: add proper raw access support Boris Brezillon
2014-11-30 18:10 ` [PATCH v6 1/3] mtd: nand: gpmi: add gpmi_copy_bits function Boris Brezillon
2014-11-30 18:10 ` [PATCH v6 2/3] mtd: nand: gpmi: add proper raw access support Boris Brezillon
2014-11-30 18:10 ` [PATCH v6 3/3] mtd: nand: gpmi: add raw oob access functions Boris Brezillon
2014-12-01  8:47 ` [PATCH v6 0/3] mtd: nand: gpmi: add proper raw access support Brian Norris
2014-12-01  8:58   ` Boris Brezillon
2014-12-02  0:47     ` Huang Shijie
2014-12-02  8:21       ` Boris Brezillon
2014-12-02 18:01         ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141202180101.GK21347@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox