linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] ARM: BCM5301X: Add DT for Asus RT-N18U
Date: Wed, 3 Dec 2014 08:50:16 +0100	[thread overview]
Message-ID: <20141203075016.GG2129@pengutronix.de> (raw)
In-Reply-To: <CACna6rzhUhzdzCCTKQ=RETb_40XqinwcrY6rzab7xQb_Vm5atw@mail.gmail.com>

Hello Rafa?,

On Wed, Dec 03, 2014 at 07:01:42AM +0100, Rafa? Mi?ecki wrote:
> On 3 December 2014 at 06:40, Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> > On 3 December 2014 at 00:19, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >> On 11/30/2014 06:28 PM, Rafa? Mi?ecki wrote:
> >>> +     compatible = "asus,rt-n18u", "brcm,bcm47081";
> >>
> >> Instead of adding bcm47081 to the core code you can do this:
> >>
> >> compatible = "asus,rt-n18u", "brcm,bcm47081", "brcm,bcm4708";
> >>
> >> If we later need some special handling for bcm47081 we can add this but
> >> the old dts file will still work. This is more relevant if the dts file
> >> is in the boot loader.
> >
> > I don't get it. How should I detect there is no second CPU?
> 
> Or did you mean using fact that currently we don't boot the second
> CPU? I don't think we can do that. We should describe the hardware,
> not drivers/arch capabilities. We shouldn't change DTS after adding
> support for boooting 2nd CPU core.
Adding brcm,bcm4708 to the list of compatibles doesn't imply that there
is a 2nd cpu. The semantic is:

	if (kernel_knows_how_to_handle(asus,rt-n18u))
		handle(as=asus,rt-n18u);
	else if (kernel_knows_how_to_handle(brcm,bcm47081))
		handle(as=brcm,bcm47081);
	else if (kernel_knows_how_to_handle(brcm,bcm4708))
		handle(as=brcm,bcm4708);

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2014-12-03  7:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-30 17:28 [PATCH 1/5] ARM: BCM5301X: Add buttons for Netgear R6250 Rafał Miłecki
2014-11-30 17:28 ` [PATCH 2/5] ARM: BCM5301X: Add DT for Netgear R6300 V2 Rafał Miłecki
2014-12-02 23:15   ` Hauke Mehrtens
2014-12-03  5:59     ` Rafał Miłecki
2014-12-03  8:40       ` Hauke Mehrtens
2014-12-03 10:25         ` Arnd Bergmann
2014-12-04  9:22   ` [PATCH V2 " Rafał Miłecki
2014-11-30 17:28 ` [PATCH 3/5] ARM: BCM5301X: Add DT for Buffalo WZR-1750DHP Rafał Miłecki
2014-12-04  9:22   ` [PATCH V2 " Rafał Miłecki
2014-11-30 17:28 ` [PATCH 4/5] ARM: BCM5301X: Add DT for Asus RT-N18U Rafał Miłecki
2014-12-02 23:19   ` Hauke Mehrtens
2014-12-03  5:40     ` Rafał Miłecki
2014-12-03  6:01       ` Rafał Miłecki
2014-12-03  7:50         ` Uwe Kleine-König [this message]
2014-12-03  8:34       ` Hauke Mehrtens
2014-12-04  9:12       ` Rafał Miłecki
2014-12-04  9:23   ` [PATCH V2 " Rafał Miłecki
2014-11-30 17:28 ` [PATCH 5/5] ARM: BCM5301X: Add DT for Buffalo WZR-600DHP2 Rafał Miłecki
2014-12-04  9:24   ` [PATCH V2 " Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203075016.GG2129@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).