linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] power: reset: adjust priority of simple syscon reboot driver
Date: Wed, 3 Dec 2014 10:27:22 +0000	[thread overview]
Message-ID: <20141203102722.GB21310@leverpostej> (raw)
In-Reply-To: <1417540320-2385-2-git-send-email-stefan@agner.ch>

On Tue, Dec 02, 2014 at 05:11:58PM +0000, Stefan Agner wrote:
> Currently, all restart handler use the priority 128, including
> watchdogs. Probably most SoC have a watchdog, and some of them
> register it also as a restart handler. But if a SoC specifies
> a dedicated reboot capability using this syscon driver, this is
> usually the preferred reboot method. Hence, raise the priority
> of this driver to 192.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

This looks good to me.

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.

> ---
>  drivers/power/reset/syscon-reboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/syscon-reboot.c b/drivers/power/reset/syscon-reboot.c
> index 815b901..c4049f4 100644
> --- a/drivers/power/reset/syscon-reboot.c
> +++ b/drivers/power/reset/syscon-reboot.c
> @@ -68,7 +68,7 @@ static int syscon_reboot_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  
>  	ctx->restart_handler.notifier_call = syscon_restart_handle;
> -	ctx->restart_handler.priority = 128;
> +	ctx->restart_handler.priority = 192;
>  	err = register_restart_handler(&ctx->restart_handler);
>  	if (err)
>  		dev_err(dev, "can't register restart notifier (err=%d)\n", err);
> -- 
> 2.1.3
> 
> 

  parent reply	other threads:[~2014-12-03 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 17:11 [PATCH v3 0/3] power: reset: vf610 system reset controller Stefan Agner
2014-12-02 17:11 ` [PATCH v3 1/3] power: reset: adjust priority of simple syscon reboot driver Stefan Agner
2014-12-02 18:32   ` Guenter Roeck
2014-12-03 10:27   ` Mark Rutland [this message]
2014-12-02 17:11 ` [PATCH v3 2/3] ARM: dts: vf610: add system reset controller and syscon-reboot Stefan Agner
2014-12-02 17:12 ` [PATCH v3 3/3] ARM: imx_v6_v7_defconfig: add POWER_RESET_SYSCON Stefan Agner
2014-12-16  4:11 ` [PATCH v3 0/3] power: reset: vf610 system reset controller Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141203102722.GB21310@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).