From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] i2c: davinci: generate STP always when NACK is received
Date: Thu, 4 Dec 2014 19:28:28 +0100 [thread overview]
Message-ID: <20141204182828.GG7944@katana> (raw)
In-Reply-To: <1417448047-15236-3-git-send-email-grygorii.strashko@ti.com>
On Mon, Dec 01, 2014 at 05:34:04PM +0200, Grygorii Strashko wrote:
> According to I2C specification the NACK should be handled as follows:
> "When SDA remains HIGH during this ninth clock pulse, this is defined as the Not
> Acknowledge signal. The master can then generate either a STOP condition to
> abort the transfer, or a repeated START condition to start a new transfer."
> [I2C spec Rev. 6, 3.1.6: http://www.nxp.com/documents/user_manual/UM10204.pdf]
>
> Currently the Davinci i2c driver interrupts the transfer on receipt of a
> NACK but fails to send a STOP in some situations and so makes the bus
> stuck until next I2C IP reset (idle/enable).
>
> For example, the issue will happen during SMBus read transfer which
> consists from two i2c messages write command/address and read data:
>
> S Slave Address Wr A Command Code A Sr Slave Address Rd A D1..Dn A P
Applied to for-current, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/780d400f/attachment.sig>
next prev parent reply other threads:[~2014-12-04 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 15:34 [PATCH v3 0/5] i2c: davinci improvements and fixes Grygorii Strashko
2014-12-01 15:34 ` [PATCH v3 1/5] i2c: i2c-davinci: switch to use platform_get_irq Grygorii Strashko
2014-12-04 18:28 ` Wolfram Sang
2014-12-01 15:34 ` [PATCH v3 2/5] i2c: davinci: generate STP always when NACK is received Grygorii Strashko
2014-12-04 18:28 ` Wolfram Sang [this message]
2014-12-01 15:34 ` [PATCH v3 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery Grygorii Strashko
2014-12-04 18:29 ` Wolfram Sang
2015-03-05 18:41 ` Grygorii Strashko
2015-03-12 11:32 ` Alexander Sverdlin
2015-03-13 10:15 ` Grygorii.Strashko@linaro.org
2015-03-13 15:45 ` Felipe Balbi
2014-12-01 15:34 ` [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure Grygorii Strashko
2015-03-12 11:45 ` Alexander Sverdlin
2015-03-18 20:31 ` Wolfram Sang
2015-03-20 18:32 ` Grygorii.Strashko@linaro.org
2015-04-03 20:18 ` Wolfram Sang
2015-04-06 13:11 ` Grygorii.Strashko@linaro.org
2015-04-06 16:09 ` Wolfram Sang
2015-04-06 16:28 ` Grygorii.Strashko@linaro.org
2014-12-01 15:34 ` [PATCH 5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery Grygorii Strashko
2015-04-01 14:38 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204182828.GG7944@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox