From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers
Date: Thu, 4 Dec 2014 19:32:43 +0100 [thread overview]
Message-ID: <20141204183242.GJ7944@katana> (raw)
In-Reply-To: <1417610126-7957-2-git-send-email-harinik@xilinx.com>
> + /*
> + * If the device is sending data If there is further
> + * data to be sent. Calculate the available space
> + * in FIFO and fill the FIFO with that many bytes.
> + */
This comment looks broken. In general, I think there should be more
comments explaining why things have to be done this way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141204/f1e23a22/attachment.sig>
next prev parent reply other threads:[~2014-12-04 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 12:35 [PATCH v2 0/3] Cadence I2C driver fixes Harini Katakam
2014-12-03 12:35 ` [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers Harini Katakam
2014-12-04 18:32 ` Wolfram Sang [this message]
2014-12-05 4:20 ` Harini Katakam
2014-12-05 5:41 ` rajeev kumar
2014-12-05 5:57 ` Harini Katakam
2014-12-05 8:15 ` Michal Simek
2014-12-03 12:35 ` [PATCH v2 2/3] i2c: cadence: Set the hardware time-out register to maximum value Harini Katakam
2014-12-04 18:30 ` Wolfram Sang
2014-12-03 12:35 ` [PATCH v2 3/3] i2c: cadence: Check for errata condition involving master receive Harini Katakam
2014-12-04 18:34 ` Wolfram Sang
2014-12-05 4:12 ` Harini Katakam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204183242.GJ7944@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).