linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: ls1021a: setup hrtimer based tick broadcast
Date: Fri, 5 Dec 2014 10:27:14 +0000	[thread overview]
Message-ID: <20141205102714.GD11889@leverpostej> (raw)
In-Reply-To: <1417770449-3492-1-git-send-email-jingchang.lu@freescale.com>

Hi,

On Fri, Dec 05, 2014 at 09:07:29AM +0000, Jingchang Lu wrote:
> This adds setup of hrtimer based tick broadcast to utilize
> the hrtimer in SMP without other broadcast tick devices.
> 
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>

This shouldn't live in board code.

Similarly to what happens with the generic dummy timer on all arches
that select it (and the broadcast hrtimer on all arches that use it so
far), we should just unconditionally register the broadcast hrtimer.

A real broadcast-capable clock event device will take preference if
present, so we don't need to add board-specific code to only register
this in certain conditions.

Mark.

> ---
>  arch/arm/mach-imx/mach-ls1021a.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/mach-ls1021a.c b/arch/arm/mach-imx/mach-ls1021a.c
> index b89c858..4d074cf 100644
> --- a/arch/arm/mach-imx/mach-ls1021a.c
> +++ b/arch/arm/mach-imx/mach-ls1021a.c
> @@ -7,6 +7,10 @@
>   * (at your option) any later version.
>   */
>  
> +#include <linux/clockchips.h>
> +#include <linux/clk-provider.h>
> +#include <linux/clocksource.h>
> +
>  #include <asm/mach/arch.h>
>  
>  #include "common.h"
> @@ -16,7 +20,15 @@ static const char * const ls1021a_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> +static void __init ls1021a_init_time(void)
> +{
> +	of_clk_init(NULL);
> +	clocksource_of_init();
> +	tick_setup_hrtimer_broadcast();
> +}
> +
>  DT_MACHINE_START(LS1021A, "Freescale LS1021A")
>  	.smp		= smp_ops(ls1021a_smp_ops),
> +	.init_time	= ls1021a_init_time,
>  	.dt_compat	= ls1021a_dt_compat,
>  MACHINE_END
> -- 
> 1.8.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

  reply	other threads:[~2014-12-05 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  9:07 [PATCH] arm: ls1021a: setup hrtimer based tick broadcast Jingchang Lu
2014-12-05 10:27 ` Mark Rutland [this message]
2014-12-05 10:57   ` Preeti U Murthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141205102714.GD11889@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).