From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: boot: dts: am437x-sk: fix lcd enable pin mux data
Date: Wed, 10 Dec 2014 08:31:47 -0800 [thread overview]
Message-ID: <20141210163147.GC30437@atomide.com> (raw)
In-Reply-To: <1417705821-21847-1-git-send-email-balbi@ti.com>
* Felipe Balbi <balbi@ti.com> [141204 07:12]:
> Caused by a copy & paste error. Note that even with
> this bug AM437x SK display still works because GPIO
> mux mode is always enabled. It's still wrong to mux
> somebody else's pin.
>
> Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x
> isn't used for anything.
>
> While at that, also replace a pullup with a pulldown
> as that gpio should be normally low, not high.
>
> Cc: <stable@vger.kernel.org> # v3.17+
> Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Applying into omap-for-v3.19/fixes thanks.
Tony
> ---
> arch/arm/boot/dts/am437x-sk-evm.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index f7f77a7..0eceb8a 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -320,8 +320,7 @@
>
> lcd_pins: lcd_pins {
> pinctrl-single,pins = <
> - /* GPIO 5_8 to select LCD / HDMI */
> - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7)
> + 0x1c (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpcm_ad7.gpio1_7 */
> >;
> };
> };
> --
> 2.1.0.GIT
>
next prev parent reply other threads:[~2014-12-10 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 18:28 [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation Felipe Balbi
2014-10-14 18:28 ` [PATCH 2/3] video: fbdev: omap2: omapfb: add missing MODULE_ALIAS() Felipe Balbi
2014-10-14 18:34 ` Felipe Balbi
2014-10-15 12:46 ` Tomi Valkeinen
2014-10-15 14:37 ` Felipe Balbi
2014-10-15 12:20 ` Tomi Valkeinen
2014-10-15 14:38 ` Felipe Balbi
2014-10-15 15:45 ` Tomi Valkeinen
2014-10-14 18:28 ` [PATCH 3/3] arm: boot: dts: am437x-sk: fix lcd enable pin mux data Felipe Balbi
2014-10-15 12:24 ` Tomi Valkeinen
2014-12-04 14:43 ` Felipe Balbi
2014-12-04 15:05 ` Felipe Balbi
2014-12-04 15:10 ` [PATCH] " Felipe Balbi
2014-12-10 16:31 ` Tony Lindgren [this message]
2014-10-15 12:13 ` [PATCH 1/3] video: fbdev: omap2: omapfb: remove __exit annotation Tomi Valkeinen
2014-10-15 14:41 ` Felipe Balbi
2014-10-15 15:43 ` Tomi Valkeinen
2014-10-15 15:54 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141210163147.GC30437@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).