From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Wed, 10 Dec 2014 08:31:47 -0800 Subject: [PATCH] arm: boot: dts: am437x-sk: fix lcd enable pin mux data In-Reply-To: <1417705821-21847-1-git-send-email-balbi@ti.com> References: <20141204144325.GA17269@saruman> <1417705821-21847-1-git-send-email-balbi@ti.com> Message-ID: <20141210163147.GC30437@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Felipe Balbi [141204 07:12]: > Caused by a copy & paste error. Note that even with > this bug AM437x SK display still works because GPIO > mux mode is always enabled. It's still wrong to mux > somebody else's pin. > > Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x > isn't used for anything. > > While at that, also replace a pullup with a pulldown > as that gpio should be normally low, not high. > > Cc: # v3.17+ > Acked-by: Tomi Valkeinen > Signed-off-by: Felipe Balbi Applying into omap-for-v3.19/fixes thanks. Tony > --- > arch/arm/boot/dts/am437x-sk-evm.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > index f7f77a7..0eceb8a 100644 > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > @@ -320,8 +320,7 @@ > > lcd_pins: lcd_pins { > pinctrl-single,pins = < > - /* GPIO 5_8 to select LCD / HDMI */ > - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > + 0x1c (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpcm_ad7.gpio1_7 */ > >; > }; > }; > -- > 2.1.0.GIT >