* [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree
@ 2014-12-09 4:21 Simon Horman
2014-12-09 8:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2014-12-09 4:21 UTC (permalink / raw)
To: linux-arm-kernel
From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
[horms: resolved conflicts]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
Based on the renesas-devel-20141209-v3.18 tag of my renesas tree
* Update by Simon Horman
- Use SGX rather than GP in clock name to reflect datasheet
---
arch/arm/boot/dts/r8a7791.dtsi | 8 +++++---
include/dt-bindings/clock/r8a7791-clock.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 958a69b..78d6371 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -1154,15 +1154,17 @@
mstp8_clks: mstp8_clks at e6150990 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
- clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>, <&zs_clk>,
- <&zs_clk>;
+ clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
+ <&zs_clk>, <&zs_clk>;
#clock-cells = <1>;
clock-indices = <
+ R8A7791_CLK_IPMMU_SGX
R8A7791_CLK_VIN2 R8A7791_CLK_VIN1 R8A7791_CLK_VIN0
R8A7791_CLK_ETHER R8A7791_CLK_SATA1 R8A7791_CLK_SATA0
>;
clock-output-names =
- "vin2", "vin1", "vin0", "ether", "sata1", "sata0";
+ "ipmmu_sgx", "vin2", "vin1", "vin0", "ether", "sata1",
+ "sata0";
};
mstp9_clks: mstp9_clks at e6150994 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
diff --git a/include/dt-bindings/clock/r8a7791-clock.h b/include/dt-bindings/clock/r8a7791-clock.h
index 3ea2bbc..ee9bb944 100644
--- a/include/dt-bindings/clock/r8a7791-clock.h
+++ b/include/dt-bindings/clock/r8a7791-clock.h
@@ -91,6 +91,7 @@
#define R8A7791_CLK_LVDS0 26
/* MSTP8 */
+#define R8A7791_CLK_IPMMU_SGX 0
#define R8A7791_CLK_VIN2 9
#define R8A7791_CLK_VIN1 10
#define R8A7791_CLK_VIN0 11
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree
2014-12-09 4:21 [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree Simon Horman
@ 2014-12-09 8:59 ` Geert Uytterhoeven
2014-12-10 0:27 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2014-12-09 8:59 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 9, 2014 at 5:21 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
>
> Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> [horms: resolved conflicts]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Looks OK to me...
> ---
>
> Based on the renesas-devel-20141209-v3.18 tag of my renesas tree
>
> * Update by Simon Horman
> - Use SGX rather than GP in clock name to reflect datasheet
> ---
> arch/arm/boot/dts/r8a7791.dtsi | 8 +++++---
> include/dt-bindings/clock/r8a7791-clock.h | 1 +
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> index 958a69b..78d6371 100644
> --- a/arch/arm/boot/dts/r8a7791.dtsi
> +++ b/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1154,15 +1154,17 @@
> mstp8_clks: mstp8_clks at e6150990 {
> compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
> reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> - clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>, <&zs_clk>,
> - <&zs_clk>;
> + clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> + <&zs_clk>, <&zs_clk>;
... but I couldn't find the parent clock in the documentation.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree
2014-12-09 8:59 ` Geert Uytterhoeven
@ 2014-12-10 0:27 ` Simon Horman
2014-12-11 0:30 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2014-12-10 0:27 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 09, 2014 at 09:59:12AM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 9, 2014 at 5:21 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> > From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> >
> > Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> > [horms: resolved conflicts]
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Looks OK to me...
>
> > ---
> >
> > Based on the renesas-devel-20141209-v3.18 tag of my renesas tree
> >
> > * Update by Simon Horman
> > - Use SGX rather than GP in clock name to reflect datasheet
> > ---
> > arch/arm/boot/dts/r8a7791.dtsi | 8 +++++---
> > include/dt-bindings/clock/r8a7791-clock.h | 1 +
> > 2 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> > index 958a69b..78d6371 100644
> > --- a/arch/arm/boot/dts/r8a7791.dtsi
> > +++ b/arch/arm/boot/dts/r8a7791.dtsi
> > @@ -1154,15 +1154,17 @@
> > mstp8_clks: mstp8_clks at e6150990 {
> > compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
> > reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> > - clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>, <&zs_clk>,
> > - <&zs_clk>;
> > + clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> > + <&zs_clk>, <&zs_clk>;
>
> ... but I couldn't find the parent clock in the documentation.
I believe we can trust Kataoka-san, but I can confirm the parent clock
with hip if you like.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree
2014-12-10 0:27 ` Simon Horman
@ 2014-12-11 0:30 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-12-11 0:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 10, 2014 at 09:27:40AM +0900, Simon Horman wrote:
> On Tue, Dec 09, 2014 at 09:59:12AM +0100, Geert Uytterhoeven wrote:
> > On Tue, Dec 9, 2014 at 5:21 AM, Simon Horman <horms+renesas@verge.net.au> wrote:
> > > From: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> > >
> > > Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@renesas.com>
> > > [horms: resolved conflicts]
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Looks OK to me...
> >
> > > ---
> > >
> > > Based on the renesas-devel-20141209-v3.18 tag of my renesas tree
> > >
> > > * Update by Simon Horman
> > > - Use SGX rather than GP in clock name to reflect datasheet
> > > ---
> > > arch/arm/boot/dts/r8a7791.dtsi | 8 +++++---
> > > include/dt-bindings/clock/r8a7791-clock.h | 1 +
> > > 2 files changed, 6 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> > > index 958a69b..78d6371 100644
> > > --- a/arch/arm/boot/dts/r8a7791.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7791.dtsi
> > > @@ -1154,15 +1154,17 @@
> > > mstp8_clks: mstp8_clks at e6150990 {
> > > compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
> > > reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> > > - clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>, <&zs_clk>,
> > > - <&zs_clk>;
> > > + clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> > > + <&zs_clk>, <&zs_clk>;
> >
> > ... but I couldn't find the parent clock in the documentation.
>
> I believe we can trust Kataoka-san, but I can confirm the parent clock
> with hip if you like.
I have decided to queue up this patch for v3.20.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-11 0:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 4:21 [PATCH] ARM: shmobile: r8a7791: Add IPMMU-SGX clock to device tree Simon Horman
2014-12-09 8:59 ` Geert Uytterhoeven
2014-12-10 0:27 ` Simon Horman
2014-12-11 0:30 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).