From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: bluetooth: Add hci_h4p driver
Date: Sun, 14 Dec 2014 20:21:24 +0100 [thread overview]
Message-ID: <20141214192124.GA22392@amd> (raw)
In-Reply-To: <570BAC61-3137-42E5-B4F8-A61AEED380DE@holtmann.org>
Hi!
> > Hacks surrounding bluetooth address were removed; this results in
> > working driver with address that is probably not unique.
>
> Just set HCI_QUIRK_INVALID_BDADDR and let someone deal with that in userspace. You can use the btmgmt public-addr command for testing.
>
Ok, it took me a while to figure out that --enable-experimental is
needed.
Then help was playing tricks with me:
For more information on the usage of each command use:
btmgmt <command> --help
root at n900:/my/bluez-5.26/tools# ./btmgmt public-addr --help
Set Public Address for hci0 failed with status 0x0b (Rejected)
root at n900:/my/bluez-5.26/tools# ./btmgmt public-addr
Usage: btmgmt public-addr <address>
root at n900:/my/bluez-5.26/tools# ./btmgmt public-addr 01:02:03:04:05:06
Set Public Address for hci0 failed with status 0x0b (Rejected)
Hmm. Since setting public address only works when interface is down,
and we lose all the settings during up, this does not work at all,
right?
Anyway, you might want to apply this to lessen the confusion.
diff -ur bluez-5.26.ofic/tools/btmgmt.c bluez-5.26/tools/btmgmt.c
--- bluez-5.26.ofic/tools/btmgmt.c 2014-12-14 12:32:19.742595000 +0100
+++ bluez-5.26/tools/btmgmt.c 2014-12-14 20:06:40.432497000 +0100
@@ -2603,7 +2603,7 @@
static void static_addr_usage(void)
{
- printf("Usage: btmgmt static-addr <address>\n");
+ printf("Usage: btmgmt static-addr ??:??:??:??:??:??\n");
}
static void cmd_static_addr(struct mgmt *mgmt, uint16_t index,
@@ -2660,7 +2660,8 @@
struct mgmt_cp_set_public_address cp;
if (argc < 2) {
- printf("Usage: btmgmt public-addr <address>\n");
+ printf("Usage: btmgmt public-addr ??:??:??:??:??:??\n"
+ "Note: interface must be down for this to work\n");
exit(EXIT_FAILURE);
}
@@ -2934,7 +2935,7 @@
static void add_device_usage(void)
{
- printf("Usage: btmgmt add-device [-a action] [-t type] <address>\n");
+ printf("Usage: btmgmt add-device [-a action] [-t type] ??:??:??:??:??:??\n");
}
static struct option add_device_options[] = {
@@ -3007,7 +3008,7 @@
static void del_device_usage(void)
{
- printf("Usage: btmgmt del-device [-t type] <address>\n");
+ printf("Usage: btmgmt del-device [-t type] ??:??:??:??:??:??\n");
}
static struct option del_device_options[] = {
@@ -3153,7 +3154,7 @@
printf("\n"
"For more information on the usage of each command use:\n"
- "\tbtmgmt <command> --help\n" );
+ "\tbtmgmt <command>\n" );
}
static struct option main_options[] = {
Only in bluez-5.26/tools: btmgmt.c~
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-12-14 19:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 22:37 bluetooth: Add hci_h4p driver Pavel Machek
2014-12-13 23:30 ` Marcel Holtmann
2014-12-13 23:51 ` Pavel Machek
2014-12-14 0:07 ` Marcel Holtmann
2014-12-14 9:47 ` Pavel Machek
2014-12-14 10:40 ` Pavel Machek
2014-12-14 11:16 ` Pavel Machek
2014-12-14 19:21 ` Pavel Machek [this message]
2014-12-14 20:28 ` Marcel Holtmann
2014-12-14 22:41 ` Pavel Machek
2014-12-14 21:52 ` Pavel Machek
2014-12-15 10:01 ` Oliver Neukum
2014-12-18 19:31 ` Pavel Machek
2014-12-18 20:10 ` Pavel Machek
2014-12-15 12:10 ` Marcel Holtmann
2014-12-19 9:50 ` Pavel Machek
2014-12-19 9:58 ` Marcel Holtmann
2014-12-20 15:48 ` Pavel Machek
2014-12-20 23:39 ` Marcel Holtmann
2014-12-20 20:23 ` [PATCH] " Pavel Machek
2014-12-20 20:43 ` Paul Bolle
2014-12-20 23:35 ` Marcel Holtmann
2014-12-23 12:00 ` Pavel Machek
2014-12-23 12:41 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141214192124.GA22392@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).