[PATCH 0/3] Add support for APM X-Gene SoC AHBC IOMMU driver.

[PATCH 0/3] Add support for APM X-Gene SoC AHBC IOMMU driver.

[Don Dutile]

You should be cc-ing Mark Langsdorf, not myself, for Xgene kernel support.

also note: I'm already on the IOMMU mailing list, so I'll see such patches via
that list.

- Don

On 12/15/2014 11:55 AM, Suman Tripathi wrote:
> This patch adds the support for the APM X-Gene SoC AHBC IOMMU driver.
>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
>
> Suman Tripathi (3):
>    xgene-ahbc-iommu: Add support for APM X-Gene SoC AHBC IOMMU driver.
>    arm64: dts: Add the APM X-Gene AHBC IOMMU DTS node.
>    Documentation: dt-bindings: Add the binding info for APM X-Gene AHBC
>      IOMMU driver.
>
>   .../devicetree/bindings/iommu/xgene,ahbc-iommu.txt |  17 ++
>   arch/arm64/boot/dts/apm-storm.dtsi                 |   5 +
>   drivers/iommu/Kconfig                              |  10 +
>   drivers/iommu/Makefile                             |   1 +
>   drivers/iommu/xgene-ahbc-iommu.c                   | 336 +++++++++++++++++++++
>   5 files changed, 369 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/iommu/xgene,ahbc-iommu.txt
>   create mode 100644 drivers/iommu/xgene-ahbc-iommu.c
>
> --
> 1.8.2.1
>

[PATCH 0/3] Add support for APM X-Gene SoC AHBC IOMMU driver.

[Don Dutile]

On 12/15/2014 11:55 AM, Suman Tripathi wrote:
> This patch adds the support for the APM X-Gene SoC AHBC IOMMU driver.
>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
>
> Suman Tripathi (3):
>    xgene-ahbc-iommu: Add support for APM X-Gene SoC AHBC IOMMU driver.
>    arm64: dts: Add the APM X-Gene AHBC IOMMU DTS node.
>    Documentation: dt-bindings: Add the binding info for APM X-Gene AHBC
>      IOMMU driver.
>
>   .../devicetree/bindings/iommu/xgene,ahbc-iommu.txt |  17 ++
>   arch/arm64/boot/dts/apm-storm.dtsi                 |   5 +
>   drivers/iommu/Kconfig                              |  10 +
>   drivers/iommu/Makefile                             |   1 +
>   drivers/iommu/xgene-ahbc-iommu.c                   | 336 +++++++++++++++++++++
>   5 files changed, 369 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/iommu/xgene,ahbc-iommu.txt
>   create mode 100644 drivers/iommu/xgene-ahbc-iommu.c
>
> --
> 1.8.2.1
>

Have you tested this with a kernel that uses 64K page size ?

[PATCH 0/3] Add support for APM X-Gene SoC AHBC IOMMU driver.

[Joerg Roedel]

Hi Suman,

On Tue, Dec 16, 2014 at 01:31:58AM +0530, Suman Tripathi wrote:
> On Dec 16, 2014 1:25 AM, "Don Dutile" <ddutile@redhat.com> wrote:
> 
>     On 12/15/2014 11:55 AM, Suman Tripathi wrote:
> 
>         This patch adds the support for the APM X-Gene SoC AHBC IOMMU driver.
> 
>         Signed-off-by: Suman Tripathi <stripathi@apm.com>
>         ---
> 
>         Suman Tripathi (3):
>         ? ?xgene-ahbc-iommu: Add support for APM X-Gene SoC AHBC IOMMU driver.
>         ? ?arm64: dts: Add the APM X-Gene AHBC IOMMU DTS node.
>         ? ?Documentation: dt-bindings: Add the binding info for APM X-Gene AHBC
>         ? ? ?IOMMU driver.
> 
>         ? .../devicetree/bindings/iommu/xgene,ahbc-iommu.txt |? 17 ++
>         ? arch/arm64/boot/dts/apm-storm.dtsi? ? ? ? ? ? ? ? ?|? ?5 +
>         ? drivers/iommu/Kconfig? ? ? ? ? ? ? ? ? ? ? ? ? ? ? |? 10 +
>         ? drivers/iommu/Makefile? ? ? ? ? ? ? ? ? ? ? ? ? ? ?|? ?1 +
>         ? drivers/iommu/xgene-ahbc-iommu.c? ? ? ? ? ? ? ? ? ?| 336
>         +++++++++++++++++++++
>         ? 5 files changed, 369 insertions(+)
>         ? create mode 100644 Documentation/devicetree/bindings/iommu/
>         xgene,ahbc-iommu.txt
>         ? create mode 100644 drivers/iommu/xgene-ahbc-iommu.c

What are the differences between the X-Gene IOMMU and the ARM-SMMU?


	Joerg

[PATCH 1/3] xgene-ahbc-iommu: Add support for APM X-Gene SoC AHBC IOMMU driver.

[Arnd Bergmann]

On Monday 15 December 2014 22:25:21 Suman Tripathi wrote:
> +       return 0;
> +}
> +
> +static struct of_device_id xgene_ahbc_mmu_of_match[] = {
> +       { .compatible = "apm,xgene-ahbc-iommu"},
> +       { },
> +};
> +MODULE_DEVICE_TABLE(of, xgene_ahbc_mmu_of_match);
> +
> +static struct platform_driver xgene_ahbc_mmu_driver = {
> +       .probe          = xgene_ahbc_mmu_probe,
> +       .remove         = xgene_ahbc_mmu_remove,
> +       .driver = {
> +               .owner  = THIS_MODULE,
> +               .name   = "xgene-ahbc",
> +               .of_match_table = of_match_ptr(xgene_ahbc_mmu_of_match),
> +       },
> +};
> +
> +static int xgene_ahbc_mmu_init(void)
> +{
> +       return platform_driver_register(&xgene_ahbc_mmu_driver);
> +}
> +subsys_initcall(xgene_ahbc_mmu_init);
> +
> +static void __exit xgene_ahbc_mmu_exit(void)
> +{
> +       platform_driver_unregister(&xgene_ahbc_mmu_driver);
> +}
> +module_exit(xgene_ahbc_mmu_exit);
> 

This should use the newly added of_iommu infrastructure that we
added for 3.19. Otherwise you are just duplicating common code.

	Arnd

[PATCH 3/3] Documentation: dt-bindings: Add the binding info for APM X-Gene AHBC IOMMU driver.

[Arnd Bergmann]

On Monday 15 December 2014 22:25:23 Suman Tripathi wrote:
> +*APM X-Gene AHBC IOMMU Architecture Implementation
> +
> +APM X-Gene SoC AHBC IOMMU translates the AHBC 32-bit address from
> +dma master to 42-bit AXI address by using a set of AIM(AHB Inbound mapper)
> +register.
> +
> +** AHBC IOMMU required properties:
> +
> +- compatible    : Should be "apm,xgene-ahbc-iommu"
> +- reg           : Base address of the AHBC AXI mapper registers
> +
> +Example:
> +
> +               ahbc_iommu: ahbc_iommu at 0x1f2a0080 {
> +                       compatible = "apm,xgene-ahbc-iommu";
> +                       reg = <0x0 0x1f2a0080 0x0 0x90>;
> +               };
> --
> 1.8.2.1
> 

This is incompatible with the iommu binding from 
Documentation/devicetree/bindings/iommu/iommu.txt

Please fix.

	Arnd