From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP3: clock: fix boot breakage in legacy mode
Date: Mon, 15 Dec 2014 16:52:06 -0800 [thread overview]
Message-ID: <20141216005206.GD23854@atomide.com> (raw)
In-Reply-To: <20141215225855.GB23854@atomide.com>
* Tony Lindgren <tony@atomide.com> [141215 15:04]:
> * Kevin Hilman <khilman@kernel.org> [141215 10:26]:
> > Tero Kristo <t-kristo@ti.com> writes:
> >
> > > On 12/12/2014 09:07 PM, Kevin Hilman wrote:
> > >> Hi Tero,
> > >>
> > >> Tero Kristo <t-kristo@ti.com> writes:
> > >>
> > >>> The new usage of determine_rate and set_rate_and_parent calls for
> > >>> OMAP DPLLs assumes the DPLLs must have two parents defined, even
> > >>> if it is the same clock. Legacy clock data did not fullfill this
> > >>> requirement and caused a boot crash. Fixed by adding the missing
> > >>> parent information to the DPLL clocks.
> > >>>
> > >>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > >>> Fixes: 2e1a7b014f ("ARM: OMAP3+: DPLL: use determine_rate() and...")
> > >>> Cc: Kevin Hilman <khilman@kernel.org>
> > >>
> > >> I tested this on linux-next (next-20141210, same version where I found
> > >> the bug) and this doesn't fix the boot problem.
> > >>
> > >> BTW, in testing this, I noticed that the OMAP clock code is still
> > >> spitting out compile warnings[1]. These should cleaned up too.
> > >
> > > Did you apply both of my patches from this set?
> >
> > No, I didn't. That wasn't clear (to me) from the changelogs.
>
> The first one Mike is alredy fixing in his clock branch AFAIK.
>
> > > I think the DPLL fix might be required also to get this working
> > > properly on OMAP3 legacy.
> >
> > Yup, with both applied, it's now booting fine on omap3-beagle-xm legacy
> > mode.
> >
> > Tested-by: Kevin Hilman <khilman@linaro.org>
> >
> > And, please add:
> >
> > Reported-by: Kevin Hilman <khilman@linaro.org>
> >
> > (c.f. Reported-by section in Documentation/SubmittingPatches).
>
> I'll queue the second one separately after Mike's clock changes
> hit mainline.
Just to update the status, Mike has applied this as it applies
to his tree now too.
Regards,
Tony
next prev parent reply other threads:[~2014-12-16 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 13:21 [PATCH 0/2] ARM: OMAP2+: quick clock fixes for linux-next Tero Kristo
2014-12-12 13:22 ` [PATCH 1/2] ARM: OMAP2+: clock: fix DPLL code to use new determine rate APIs Tero Kristo
2014-12-12 13:22 ` [PATCH 2/2] ARM: OMAP3: clock: fix boot breakage in legacy mode Tero Kristo
2014-12-12 19:07 ` Kevin Hilman
2014-12-15 7:56 ` Tero Kristo
2014-12-15 18:23 ` Kevin Hilman
2014-12-15 22:58 ` Tony Lindgren
2014-12-16 0:52 ` Tony Lindgren [this message]
2014-12-15 4:35 ` [PATCH 0/2] ARM: OMAP2+: quick clock fixes for linux-next Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216005206.GD23854@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).