From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] arm: imx: correct the hardware clock gate setting for shared nodes
Date: Tue, 16 Dec 2014 17:02:20 +0800 [thread overview]
Message-ID: <20141216090218.GI2411@dragon> (raw)
In-Reply-To: <1418205102-14598-1-git-send-email-b20788@freescale.com>
On Wed, Dec 10, 2014 at 05:51:42PM +0800, Anson Huang wrote:
> For those clk gates which hold share count, since its is_enabled
> callback is only checking the share count rather than reading
> the hardware register setting, in the late phase of kernel bootup,
> the clk_disable_unused action will NOT handle the scenario of
> share_count is 0 but the hardware setting is enabled, actually,
> U-Boot normally enables all clk gates, then those shared clk gates
> will be always enabled until they are used by some modules.
>
> So the problem would be: when kernel boot up, the usecount cat
> from clk tree is 0, but the clk gates actually is enabled in
> hardware register, it will confuse user and bring unnecessary power
> consumption.
>
> This patch adds .disable_unused callback and using hardware register
> check for .is_enabled callback of shared nodes to handle such scenario
> in late phase of kernel boot up, then the hardware status will match the
> clk tree info.
>
> Signed-off-by: Anson Huang <b20788@freescale.com>
Applied, thanks.
prev parent reply other threads:[~2014-12-16 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 9:51 [PATCH V3] arm: imx: correct the hardware clock gate setting for shared nodes Anson Huang
2014-12-10 21:24 ` Stefan Agner
2014-12-10 21:33 ` Stefan Agner
2014-12-16 9:02 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216090218.GI2411@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).