From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH boot-wrapper-aarch64] configure: Fix for --with-initrd=no
Date: Wed, 17 Dec 2014 11:46:02 +0000 [thread overview]
Message-ID: <20141217114602.GA8942@leverpostej> (raw)
In-Reply-To: <5490EADF.7080906@huawei.com>
On Wed, Dec 17, 2014 at 02:30:55AM +0000, Qiang Huang wrote:
> Our configure.ac script wasn't handle --with-initrd=no, when this was passed,
> we got error:
The parameter to --with-initrd should be the name of the initrd to use;
"yes" or "no" are not valid parameters. I note that the help text is
misleading in this regard, it should probably be fixed up to say
something like "Specify an initrd to use".
While it's unlikely that someone will have an initrd called "no", this
issue can only occur with incorrect usage of the bootwrapper configure
script. I'd happily accept a patch fixing up the help text, though.
Thanks,
Mark.
> ...
> aarch64-linux-gnu-ld -o linux-system.axf --script=model.lds
> aarch64-linux-gnu-ld: cannot find no
> make: *** [linux-system.axf] Error 1
>
> Fix this by adding a line to check this.
> And this also fixed --without-initrd.
>
> Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
> Cc: Geoff Levand <geoff@infradead.org>
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 929da13..553013b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -58,6 +58,7 @@ AC_SUBST([CPU_IDS], [$C_CPU_IDS])
> AC_ARG_WITH([initrd],
> AS_HELP_STRING([--with-initrd], [embed an initrd in the kernel image]),
> USE_INITRD=$withval)
> +AS_IF([test "x$USE_INITRD" = "xno"], [USE_INITRD=], [])
> AC_SUBST([FILESYSTEM], [$USE_INITRD])
> AM_CONDITIONAL([INITRD], [test "x$USE_INITRD" != "x"])
>
> --
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2014-12-17 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 2:30 [PATCH boot-wrapper-aarch64] configure: Fix for --with-initrd=no Qiang Huang
2014-12-17 11:46 ` Mark Rutland [this message]
2014-12-18 2:58 ` Qiang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141217114602.GA8942@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).