linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scsi: arm: cumana_1.c:  Remove unused function
Date: Sat, 20 Dec 2014 17:39:04 +0000	[thread overview]
Message-ID: <20141220173904.GL11285@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1419096953.2184.3.camel@HansenPartnership.com>

On Sat, Dec 20, 2014 at 09:35:53AM -0800, James Bottomley wrote:
> On Sat, 2014-12-20 at 16:58 +0000, Russell King - ARM Linux wrote:
> > On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote:
> > > On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote:
> > > > Remove the function cumanascsi_setup() that is not used anywhere.
> > > > 
> > > > This was partially found by using a static code analysis program called cppcheck.
> > > > 
> > > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> > >
> > > You can blame Linus for this one :-)
> > > 
> > > ~/linux-next$ git blame -L 38,40 drivers/scsi/arm/cumana_1.c 
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 38) void
> > > cumanascsi_setup(char *str, int *ints)
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 39) {
> > > ^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) }
> > > ~/linux-next$
> > 
> > Great, that gets me off the hook :)
> 
> Well, no, it doesn't: 1da177e is the git tree root commit which was
> created by importing the existing bitkeeper version 2.6.12-rc2 into git.
> It means this code predates the git import.  You might be able to chase
> it through the history tree if you want, but that only goes back as far
> as bitkeeper history.

James, please see the smilie on the end of the comment, I wasn't being
serious.  Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2014-12-20 17:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-20 16:36 [PATCH] scsi: arm: cumana_1.c: Remove unused function Rickard Strandqvist
2014-12-20 16:50 ` Jeremiah Mahler
2014-12-20 16:55   ` Rickard Strandqvist
2014-12-20 16:58   ` Russell King - ARM Linux
2014-12-20 17:35     ` James Bottomley
2014-12-20 17:39       ` Russell King - ARM Linux [this message]
2014-12-30 12:45 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141220173904.GL11285@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).