public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more)
Date: Mon, 5 Jan 2015 12:32:52 +0000	[thread overview]
Message-ID: <20150105123252.GB10116@arm.com> (raw)
In-Reply-To: <20150105013436.GA23350@thunk.org>

Hi Ted,

On Mon, Jan 05, 2015 at 01:34:36AM +0000, Theodore Ts'o wrote:
> On Sun, Jan 04, 2015 at 09:26:59PM +0000, Russell King - ARM Linux wrote:
> > 
> > With the revert in place, we now have insanely small bogomips values
> > reported via /proc/cpuinfo when hardware timers are used.  That needs
> > fixing.
> 
> Why does it need to be fixed?
> 
> It's clear that there are applications that are working OK with the
> existing value,

I'm not sure it is that clear -- the reported regression was on a processor
that doesn't use the timer-backed delay loop, so the bogomips value will
essentially be restored by reverting the patch.

The issue comes on newer CPUs, where there will now be a very small bogomips
value reported and (to my knowledge) nobody has yet tried running some
affected applications there to see if they can cope.

> and if you change it to fix it for some new applications, but it breaks
> for others, then have you considered defining a new interface (perhaps
> exported via sysfs) that exports a "sane" value and document that new
> applications shoud use the new interface.
> 
> Or if the answer is that no one should be using the bogomips field at
> all, then just document *that*, and then leave it be, so that existing
> applications don't break.

It never hurts to document our assumptions or anticipated/preferred use-cases
but in this case I think bogomips is difficult enough to use on any
half-recent SoCs that most developers have either (a) found another way to
do what they want (perf counters, clock_gettime) or (b) stopped bothering to
guess the CPU frequency when it's not actually needed, so I don't *think*
that new applications are such an issue.

Cheers,

Will

      parent reply	other threads:[~2015-01-05 12:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150104190123.GA20153@amd>
     [not found] ` <alpine.LFD.2.11.1501041438130.18844@knanqh.ubzr>
     [not found]   ` <20150104201026.GA23427@amd>
     [not found]     ` <alpine.LFD.2.11.1501041512440.18844@knanqh.ubzr>
     [not found]       ` <20150104203724.GA16372@amd>
     [not found]         ` <alpine.LFD.2.11.1501041547050.18844@knanqh.ubzr>
     [not found]           ` <CA+55aFy5yB2d-1iXEUtU+puua4TAmV0kZF_7TBhXO1Y4Khqb9Q@mail.gmail.com>
     [not found]             ` <alpine.LFD.2.11.1501041609290.18844@knanqh.ubzr>
     [not found]               ` <20150104212659.GC12302@n2100.arm.linux.org.uk>
     [not found]                 ` <alpine.LFD.2.11.1501042343240.18844@knanqh.ubzr>
2015-01-05 12:11                   ` [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more) Will Deacon
2015-01-05 15:34                     ` Pavel Machek
2015-01-05 16:24                     ` Nicolas Pitre
2015-01-06  4:09                     ` Nicolas Pitre
2015-01-06 13:01                       ` Arnd Bergmann
2015-01-06 20:50                         ` Nicolas Pitre
2015-01-06 21:27                           ` Nicolas Pitre
2015-01-06 21:37                             ` Arnd Bergmann
     [not found]                 ` <20150105013436.GA23350@thunk.org>
2015-01-05 12:32                   ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150105123252.GB10116@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox