From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] arm64: fix missing linux/bug.h include in asm/arch_timer.h
Date: Tue, 6 Jan 2015 10:27:37 +0000 [thread overview]
Message-ID: <20150106102736.GA4858@leverpostej> (raw)
In-Reply-To: <20150106015210.27249.91222.stgit@dusk.lan>
Hi Paul,
On Tue, Jan 06, 2015 at 01:52:15AM +0000, Paul Walmsley wrote:
> On next-20150105, defconfig compilation breaks with:
>
> ./arch/arm64/include/asm/arch_timer.h:112:2: error: implicit declaration of function ?BUG? [-Werror=implicit-function-declaration]
>
> Fix by including linux/bug.h, where the BUG macro is defined.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Paul Walmsley <pwalmsley@nvidia.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
> arch/arm64/include/asm/arch_timer.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h
> index b1fa4e614718..779455564c9a 100644
> --- a/arch/arm64/include/asm/arch_timer.h
> +++ b/arch/arm64/include/asm/arch_timer.h
> @@ -23,6 +23,7 @@
>
> #include <linux/init.h>
> #include <linux/types.h>
> +#include <linux/bug.h>
Nit: could you move this above the include of linux/init.h so as to keep
these in alphabetical order?
Otherwise:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
>
> #include <clocksource/arm_arch_timer.h>
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2015-01-06 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 1:51 [PATCH 0/4] ARM64 compilation fixes for missing header includes Paul Walmsley
2015-01-06 1:52 ` [PATCH 1/4] arm64: fix missing asm/pgtable-hwdef.h include in asm/processor.h Paul Walmsley
2015-01-06 10:37 ` Mark Rutland
2015-01-06 20:34 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 2/4] arm64: fix missing linux/bug.h include in asm/arch_timer.h Paul Walmsley
2015-01-06 10:27 ` Mark Rutland [this message]
2015-01-06 20:30 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 3/4] arm64: fix missing asm/alternative.h include in kernel/module.c Paul Walmsley
2015-01-06 10:40 ` Mark Rutland
2015-01-06 20:36 ` Paul Walmsley
2015-01-06 1:52 ` [PATCH 4/4] arm64: fix missing asm/io.h include in kernel/smp_spin_table.c Paul Walmsley
2015-01-06 10:34 ` Mark Rutland
2015-01-06 20:32 ` Paul Walmsley
2015-01-07 11:08 ` [PATCH 0/4] ARM64 compilation fixes for missing header includes Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106102736.GA4858@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).