From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks
Date: Tue, 6 Jan 2015 16:58:32 +0100 [thread overview]
Message-ID: <20150106165832.3e29e3a9@free-electrons.com> (raw)
In-Reply-To: <1420559110-8043-3-git-send-email-maxime.ripard@free-electrons.com>
Dear Maxime Ripard,
On Tue, 6 Jan 2015 16:45:08 +0100, Maxime Ripard wrote:
> + if (of_device_is_compatible(pdev->dev.of_node,
> + "marvell,armada-375-xhci") ||
> + of_device_is_compatible(pdev->dev.of_node,
> + "marvell,armada-380-xhci")) {
> + ret = xhci_mvebu_mbus_init_quirk(pdev);
> + if (ret)
> + return ret;
> + }
So on error, you're leaking the struct usb_hcd now if I'm not mistaken.
When moving code around, the error handling should also be fixed. You
probably need "goto put_hcd;" instead of "return ret;".
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-06 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:45 [PATCH 0/4] ARM: mvebu: Enable XHCI on the A385-AP Maxime Ripard
2015-01-06 15:45 ` [PATCH 1/4] usb: phy: Fix deferred probing Maxime Ripard
2015-01-07 4:41 ` Olof Johansson
2015-01-08 16:32 ` Grygorii.Strashko@linaro.org
2015-01-08 17:24 ` Felipe Balbi
2015-01-08 18:04 ` Thierry Reding
2015-01-08 18:09 ` Felipe Balbi
2015-01-06 15:45 ` [PATCH 2/4] usb: XHCI: platform: Move the Marvell quirks after the enabling the clocks Maxime Ripard
2015-01-06 15:58 ` Thomas Petazzoni [this message]
2015-01-06 15:45 ` [PATCH 3/4] usb: xhci: plat: Add USB phy support Maxime Ripard
2015-01-06 19:39 ` Sergei Shtylyov
2015-01-06 15:45 ` [PATCH 4/4] ARM: mvebu: armada-385-ap: Enable USB3 port Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106165832.3e29e3a9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox