From: mst@redhat.com (Michael S. Tsirkin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/40] arm64/uaccess: fix sparse errors
Date: Tue, 6 Jan 2015 23:51:15 +0200 [thread overview]
Message-ID: <20150106215115.GA21594@redhat.com> (raw)
In-Reply-To: <20150106214820.GA18895@redhat.com>
On Tue, Jan 06, 2015 at 11:48:20PM +0200, Michael S. Tsirkin wrote:
> On Tue, Jan 06, 2015 at 07:14:32PM +0000, Will Deacon wrote:
> > Hi Michael,
> >
> > On Tue, Jan 06, 2015 at 03:43:40PM +0000, Michael S. Tsirkin wrote:
> > > virtio wants to read bitwise types from userspace using get_user. At the
> > > moment this triggers sparse errors, since the value is passed through an
> > > integer.
> > >
> > > Fix that up using __force.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > Acked-by: Will Deacon <will.deacon@arm.com>
> > > ---
> >
> > Did you want us to take this via the arm64 tree, or are you planning to
> > merge it via another route?
> >
> > Will
>
> Up to you really: if you don't pick it up, Arnd said he'll merge
> through his tree.
Though if you do pick it up, need to also pick up the follow-up
patch - maybe my tree is easier.
> > > arch/arm64/include/asm/uaccess.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
> > > index 3bf8f4e..9a2069b 100644
> > > --- a/arch/arm64/include/asm/uaccess.h
> > > +++ b/arch/arm64/include/asm/uaccess.h
> > > @@ -147,7 +147,7 @@ do { \
> > > default: \
> > > BUILD_BUG(); \
> > > } \
> > > - (x) = (__typeof__(*(ptr)))__gu_val; \
> > > + (x) = (__force __typeof__(*(ptr)))__gu_val; \
> > > } while (0)
> > >
> > > #define __get_user(x, ptr) \
> > > --
> > > MST
> > >
> > >
next prev parent reply other threads:[~2015-01-06 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1420558883-10131-1-git-send-email-mst@redhat.com>
2015-01-06 15:43 ` [PATCH v2 03/40] arm64/uaccess: fix sparse errors Michael S. Tsirkin
2015-01-06 19:14 ` Will Deacon
2015-01-06 21:48 ` Michael S. Tsirkin
2015-01-06 21:51 ` Michael S. Tsirkin [this message]
2015-01-07 10:09 ` Will Deacon
2015-01-06 15:44 ` [PATCH v2 17/40] arm: fix put_user " Michael S. Tsirkin
2015-01-06 15:45 ` [PATCH v2 30/40] arm: macro whitespace fixes Michael S. Tsirkin
2015-01-06 15:45 ` [PATCH v2 31/40] arm64: " Michael S. Tsirkin
2015-01-07 10:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106215115.GA21594@redhat.com \
--to=mst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).