From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mm: fix PMD_SECT_RDONLY undeclared compile error
Date: Wed, 7 Jan 2015 18:16:57 +0000 [thread overview]
Message-ID: <20150107181657.GS7485@arm.com> (raw)
In-Reply-To: <1420653969-4048-1-git-send-email-victor.kamensky@linaro.org>
On Wed, Jan 07, 2015 at 06:06:09PM +0000, Victor Kamensky wrote:
> From: Victor Kamensky <kamensky@coreos-lnx2.cisco.com>
>
> In v3.19-rc3 tree when CONFIG_ARM_LPAE and CONFIG_DEBUG_RODATA are enabled
> image failed to compile with the following error:
>
> arch/arm/mm/init.c:661:14: error: ?PMD_SECT_RDONLY? undeclared here (not in a function)
>
> It seems that '80d6b0c ARM: mm: allow text and rodata sections to be read-only'
> and 'ded9477 ARM: 8109/1: mm: Modify pte_write and pmd_write logic for LPAE'
> commits crossed. 80d6b0c uses PMD_SECT_RDONLY macro but ded9477 renames it
> and uses software bits L_PMD_SECT_RDONLY instead.
>
> Fix is to use L_PMD_SECT_RDONLY instead PMD_SECT_RDONLY as ded9477 does in
> another places.
>
> Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
> ---
> arch/arm/mm/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 98ad9c7..2495c8c 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -658,8 +658,8 @@ static struct section_perm ro_perms[] = {
> .start = (unsigned long)_stext,
> .end = (unsigned long)__init_begin,
> #ifdef CONFIG_ARM_LPAE
> - .mask = ~PMD_SECT_RDONLY,
> - .prot = PMD_SECT_RDONLY,
> + .mask = ~L_PMD_SECT_RDONLY,
> + .prot = L_PMD_SECT_RDONLY,
> #else
> .mask = ~(PMD_SECT_APX | PMD_SECT_AP_WRITE),
> .prot = PMD_SECT_APX | PMD_SECT_AP_WRITE,
> --
> 1.9.3
>
>
next prev parent reply other threads:[~2015-01-07 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 18:06 [PATCH] ARM: mm: fix PMD_SECT_RDONLY undeclared compile error Victor Kamensky
2015-01-07 18:16 ` Will Deacon [this message]
2015-01-09 17:00 ` Russell King - ARM Linux
2015-01-09 17:58 ` Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107181657.GS7485@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).