From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/5] KVM: irqfd: use kvm_arch_is_virtual_intc_initialized
Date: Sun, 11 Jan 2015 22:17:13 +0100 [thread overview]
Message-ID: <20150111211713.GF3868@cbox> (raw)
In-Reply-To: <1417622832-5460-5-git-send-email-eric.auger@linaro.org>
On Wed, Dec 03, 2014 at 05:07:11PM +0100, Eric Auger wrote:
> On arm/arm64, the interrupt controller is dynamically instantiated.
> There is a risk the user-space assigns an irqfd before this latter
> is initialized and ready to accept virtual irq injection. On such
> attempt, the IRQFD setup is rejected and -EAGAIN is returned.
>
> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> ---
> virt/kvm/eventfd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
> index b0fb390..f837c83 100644
> --- a/virt/kvm/eventfd.c
> +++ b/virt/kvm/eventfd.c
> @@ -314,6 +314,9 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
> unsigned int events;
> int idx;
>
> + if (!kvm_arch_is_virtual_intc_initialized(kvm))
> + return -EAGAIN;
> +
You can fold this into the patch that defines the static inline since
nothing defines the KVM_HAVE_ARCH_... yet.
> irqfd = kzalloc(sizeof(*irqfd), GFP_KERNEL);
> if (!irqfd)
> return -ENOMEM;
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-01-11 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 16:07 [PATCH v5 0/5] irqfd support for arm/arm64 Eric Auger
2014-12-03 16:07 ` [PATCH v5 1/5] KVM: arm/arm64: unset CONFIG_HAVE_KVM_IRQCHIP Eric Auger
2014-12-03 16:07 ` [PATCH v5 2/5] KVM: introduce kvm_arch_is_virtual_intc_initialized Eric Auger
2015-01-11 21:11 ` Christoffer Dall
2015-01-12 13:39 ` Eric Auger
2014-12-03 16:07 ` [PATCH v5 3/5] KVM: arm/arm64: implement kvm_arch_is_virtual_intc_initialized Eric Auger
2015-01-11 21:12 ` Christoffer Dall
2015-01-12 13:40 ` Eric Auger
2014-12-03 16:07 ` [PATCH v5 4/5] KVM: irqfd: use kvm_arch_is_virtual_intc_initialized Eric Auger
2015-01-11 21:17 ` Christoffer Dall [this message]
2015-01-12 13:40 ` Eric Auger
2015-01-12 16:55 ` Christoffer Dall
2014-12-03 16:07 ` [PATCH v5 5/5] KVM: arm/arm64: add irqfd support Eric Auger
2015-01-11 21:43 ` Christoffer Dall
2015-01-12 14:30 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150111211713.GF3868@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).