[PATCH] arm64: mm: dump: add missing includes

Steve Capper
2015-01-12T15:45:10Z

On 12 January 2015 at 15:40, Mark Rutland <mark.rutland@arm.com> wrote:
> The arm64 dump code is currently relying on some definitions which are
> pulled in via transitive dependencies. On next-20150112 at least one of
> these (PCI_IOBASE) is no longer pulled in with a defconfig build,
> resulting in the following build failure:
>
> arch/arm64/mm/dump.c:55:20: error: ?PCI_IOBASE? undeclared here (not in a function)
> { (unsigned long) PCI_IOBASE, "PCI I/O start" },
> ^
> It seems we have implicit dependencies on the following definitions:
>
> * PCI_IOBASE (asm/io.h)
> * MODULES_VADDR (asm/memory.h)
> * MODULES_END (asm/memory.h)
> * PAGE_OFFSET (asm/memory.h)
> * PTE_* (asm/pgtable-hwdef.h)
> * ENOMEM (asm/errno.h)
> * device_initcall (linux/init.h)
>
> This patch ensures we explicitly include the relevant headers for the
> above items, fixing the observed build issue and hopefully preventing
> future issues as headers are refactored.
>

Looks good to me.

Acked-by: Steve Capper <steve.capper@linaro.org>

> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Reported-by: Mark Brown <broonie@kernel.org>
> Cc: Catalin Marinas <Catalin.Marinas@arm.com>
> Cc: Laura Abbott <lauraa@codeaurora.org>
> Cc: Steve Capper <steve.capper@linaro.org>
> Cc: Will Deacon <Will.Deacon@arm.com>
> ---
> arch/arm64/mm/dump.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index cf33f33..df69e43 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -15,12 +15,17 @@
> */
> #include <linux/debugfs.h>
> #include <linux/fs.h>
> +#include <linux/init.h>
> #include <linux/mm.h>
> #include <linux/sched.h>
> #include <linux/seq_file.h>
>
> +#include <asm/errno.h>
> #include <asm/fixmap.h>
> +#include <asm/io.h>
> +#include <asm/memory.h>
> #include <asm/pgtable.h>
> +#include <asm/pgtable-hwdef.h>
>
> #define LOWEST_ADDR (UL(0xffffffffffffffff) << VA_BITS)
>
> --
> 1.9.1
>