linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] ARM: OMAP2+: Fix reboot for 81xx
Date: Wed, 14 Jan 2015 11:04:19 -0800	[thread overview]
Message-ID: <20150114190419.GO2419@atomide.com> (raw)
In-Reply-To: <20150114012447.GF18523@saruman>

* Felipe Balbi <balbi@ti.com> [150113 17:28]:
> On Tue, Jan 13, 2015 at 03:13:56PM -0800, Tony Lindgren wrote:
> > +
> > +#define TI81XX_PRM_DEVICE_RSTCTRL	0x00a0
> > +#define TI81XX_GLOBAL_RST_COLD		BIT(1)
> > +
> > +/**
> > + * ti81xx_restart - trigger a software restart of the SoC
> > + * @mode: the "reboot mode", see arch/arm/kernel/{setup,process}.c
> > + * @cmd: passed from the userspace program rebooting the system (if provided)
> > + *
> > + * Resets the SoC.  For @cmd, see the 'reboot' syscall in
> > + * kernel/sys.c.  No return value.
> > + */
> > +void ti81xx_restart(enum reboot_mode mode, const char *cmd)
> > +{
> > +	omap2_prm_set_mod_reg_bits(TI81XX_GLOBAL_RST_COLD, 0,
> > +				   TI81XX_PRM_DEVICE_RSTCTRL);
> 
> do you need to check that mode == REBOOT_COLD here ?

Looks like not, trying to use the warm reset bit does not seem to do
anything and probably requires manually resetting clocks into bypass
mode or something.

I'll just add a comment about that.

Regards,

Tony

  reply	other threads:[~2015-01-14 19:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 23:13 [PATCH 0/7] Fixes and clean-up in preparation for booting ti81xx Tony Lindgren
2015-01-13 23:13 ` [PATCH 1/7] ARM: OMAP2+: Remove unused ti81xx platform init code Tony Lindgren
2015-01-14  1:19   ` Felipe Balbi
2015-01-14 17:19     ` Tony Lindgren
2015-01-13 23:13 ` [PATCH 2/7] ARM: OMAP2+: Fix error handling for omap2_clk_enable_init_clocks Tony Lindgren
2015-01-14  1:21   ` Felipe Balbi
2015-01-14 17:27     ` Tony Lindgren
2015-01-13 23:13 ` [PATCH 3/7] ARM: OMAP2+: Fix ti81xx devtype Tony Lindgren
2015-01-13 23:13 ` [PATCH 4/7] ARM: OMAP2+: Fix ti81xx class type Tony Lindgren
2015-01-13 23:13 ` [PATCH 5/7] ARM: OMAP2+: Fix dm814 and dm816 for clocks and timer init Tony Lindgren
2015-01-13 23:13 ` [PATCH 6/7] ARM: OMAP2+: Fix reboot for 81xx Tony Lindgren
2015-01-14  1:24   ` Felipe Balbi
2015-01-14 19:04     ` Tony Lindgren [this message]
2015-01-14 19:30       ` Felipe Balbi
2015-01-13 23:13 ` [PATCH 7/7] ARM: OMAP2+: Disable omap3 PM init for ti81xx Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150114190419.GO2419@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).