* [PATCH v2 0/2] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts
@ 2015-01-15 13:50 Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 1/2] " Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 2/2] ARM: shmobile: r8a7790: " Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2015-01-15 13:50 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon, Magnus,
This patch series corrects the masks in the second interrupt cells for
Private Peripheral Interrupts in dtsi files for members of the
shmobile family of SoCs containing big.LITTLE configurations.
This mask should reflect the actual number of CPU cores the interrupt
is wired too. Hence on big.LITTLE configurations with four Cortex-A15
cores and four Cortex-A7 cores, like r8a7790 and r8a73a4, it should be
"GIC_CPU_MASK_SIMPLE(8)", not "GIC_CPU_MASK_SIMPLE(4)".
Note that incorrect masks for GIC PPI interrupts are not limited to
shmobile. Presumably the interrupt specifiers got copied around a lot,
cfr. the proliferation of "GIC_CPU_MASK_SIMPLE(4)" (and the older
hardcoded "0xf0x" variant) in various dtsi files, not always limited to
quad-core CPUs.
Changes compared to v1:
- Dropped patches for r8a7791 and r8a7794 that have been applied by
Simon,
- Dropped RFC status after receiving confirmation from Liviu Dudau.
This was untested on real hardware.
Thanks!
Geert Uytterhoeven (2):
ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts
ARM: shmobile: r8a7790: Correct mask for GIC PPI interrupts
arch/arm/boot/dts/r8a73a4.dtsi | 10 +++++-----
arch/arm/boot/dts/r8a7790.dtsi | 10 +++++-----
2 files changed, 10 insertions(+), 10 deletions(-)
--
1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts
2015-01-15 13:50 [PATCH v2 0/2] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts Geert Uytterhoeven
@ 2015-01-15 13:50 ` Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 2/2] ARM: shmobile: r8a7790: " Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2015-01-15 13:50 UTC (permalink / raw)
To: linux-arm-kernel
R-Mobile APE6 (r8a73a4) contains four Cortex-A15 and four Cortex-A7
cores, hence the second interrupt specifier cell for Private Peripheral
Interrupts should use "GIC_CPU_MASK_SIMPLE(8)", so GIC interrupts are
delivered to all 8 processor cores.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested
v2:
- Drop RFC status after receiving confirmation from Liviu Dudau.
---
arch/arm/boot/dts/r8a73a4.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
index 38136d9f6d95a16e..424c189640812c91 100644
--- a/arch/arm/boot/dts/r8a73a4.dtsi
+++ b/arch/arm/boot/dts/r8a73a4.dtsi
@@ -32,10 +32,10 @@
timer {
compatible = "arm,armv7-timer";
- interrupts = <1 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+ interrupts = <1 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
};
dbsc1: memory-controller at e6790000 {
@@ -375,6 +375,6 @@
<0 0xf1002000 0 0x1000>,
<0 0xf1004000 0 0x2000>,
<0 0xf1006000 0 0x2000>;
- interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+ interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/2] ARM: shmobile: r8a7790: Correct mask for GIC PPI interrupts
2015-01-15 13:50 [PATCH v2 0/2] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 1/2] " Geert Uytterhoeven
@ 2015-01-15 13:50 ` Geert Uytterhoeven
2015-01-16 1:49 ` Magnus Damm
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2015-01-15 13:50 UTC (permalink / raw)
To: linux-arm-kernel
R-Car H2 (r8a7790) contains four Cortex-A15 and four Cortex-A7 cores,
hence the second interrupt specifier cell for Private Peripheral
Interrupts should use "GIC_CPU_MASK_SIMPLE(8)", to make sure interrupts
can be delivered to all 8 processor cores.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested
v2:
- Drop RFC status after receiving confirmation from Liviu Dudau.
---
arch/arm/boot/dts/r8a7790.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 4b38fc92011472e0..1405064ff0245f47 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -120,7 +120,7 @@
<0 0xf1002000 0 0x1000>,
<0 0xf1004000 0 0x2000>,
<0 0xf1006000 0 0x2000>;
- interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
+ interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
};
gpio0: gpio at e6050000 {
@@ -204,10 +204,10 @@
timer {
compatible = "arm,armv7-timer";
- interrupts = <1 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
- <1 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+ interrupts = <1 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
+ <1 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
};
cmt0: timer at ffca0000 {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/2] ARM: shmobile: r8a7790: Correct mask for GIC PPI interrupts
2015-01-15 13:50 ` [PATCH v2 2/2] ARM: shmobile: r8a7790: " Geert Uytterhoeven
@ 2015-01-16 1:49 ` Magnus Damm
2015-01-16 2:15 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Magnus Damm @ 2015-01-16 1:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
On Thu, Jan 15, 2015 at 10:50 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> R-Car H2 (r8a7790) contains four Cortex-A15 and four Cortex-A7 cores,
> hence the second interrupt specifier cell for Private Peripheral
> Interrupts should use "GIC_CPU_MASK_SIMPLE(8)", to make sure interrupts
> can be delivered to all 8 processor cores.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Untested
>
> v2:
> - Drop RFC status after receiving confirmation from Liviu Dudau.
Thanks for your work on this.
I see the "untested" word above which makes me think we should test
both Big and Little boot modes on r8a7790. The default "Big" mode
where CA15 is used usually gets a lot of attention, but little mode
with CA7 boot should also work with the same kernel image.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] ARM: shmobile: r8a7790: Correct mask for GIC PPI interrupts
2015-01-16 1:49 ` Magnus Damm
@ 2015-01-16 2:15 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2015-01-16 2:15 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 16, 2015 at 10:49:33AM +0900, Magnus Damm wrote:
> Hi Geert,
>
> On Thu, Jan 15, 2015 at 10:50 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > R-Car H2 (r8a7790) contains four Cortex-A15 and four Cortex-A7 cores,
> > hence the second interrupt specifier cell for Private Peripheral
> > Interrupts should use "GIC_CPU_MASK_SIMPLE(8)", to make sure interrupts
> > can be delivered to all 8 processor cores.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Untested
> >
> > v2:
> > - Drop RFC status after receiving confirmation from Liviu Dudau.
>
> Thanks for your work on this.
>
> I see the "untested" word above which makes me think we should test
> both Big and Little boot modes on r8a7790. The default "Big" mode
> where CA15 is used usually gets a lot of attention, but little mode
> with CA7 boot should also work with the same kernel image.
For now I have marked these as deferred pending testing.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-16 2:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 13:50 [PATCH v2 0/2] ARM: shmobile: r8a73a4: Correct mask for GIC PPI interrupts Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 1/2] " Geert Uytterhoeven
2015-01-15 13:50 ` [PATCH v2 2/2] ARM: shmobile: r8a7790: " Geert Uytterhoeven
2015-01-16 1:49 ` Magnus Damm
2015-01-16 2:15 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).