From: sylvain.rochet@finsecur.com (Sylvain Rochet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clockevents: don't suspend/resume if unused
Date: Fri, 16 Jan 2015 10:20:14 +0100 [thread overview]
Message-ID: <20150116092014.GA27945@gradator.net> (raw)
In-Reply-To: <1421399151-26800-1-git-send-email-alexandre.belloni@free-electrons.com>
Hello Alexandre,
On Fri, Jan 16, 2015 at 10:05:51AM +0100, Alexandre Belloni wrote:
> There is no point in calling suspend/resume for unused
> clockevents as they are already stopped and disabled.
>
> Furthermore, it can take some time to wait for some IPs to stop counting.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Reported-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Indeed, this is way better from what I did.
> + if (dev->suspend && dev->mode != CLOCK_EVT_MODE_UNUSED)
I wonder if we should use > CLOCK_EVT_MODE_SHUTDOWN
(or CLOCK_EVT_MODE_UNUSED || CLOCK_EVT_MODE_SHUTDOWN) instead of
!CLOCK_EVT_MODE_UNUSED.
Sylvain
next prev parent reply other threads:[~2015-01-16 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 9:05 [PATCH] clockevents: don't suspend/resume if unused Alexandre Belloni
2015-01-16 9:20 ` Sylvain Rochet [this message]
2015-01-16 11:17 ` Russell King - ARM Linux
2015-01-16 11:20 ` Russell King - ARM Linux
2015-01-16 16:59 ` Alexandre Belloni
2015-03-06 12:54 ` Alexandre Belloni
2015-05-25 16:19 ` Alexandre Belloni
2015-05-25 16:56 ` Thomas Gleixner
2015-05-25 18:48 ` Thomas Gleixner
2015-05-25 19:06 ` Sylvain Rochet
2015-05-25 20:11 ` Thomas Gleixner
2015-05-25 20:53 ` Sylvain Rochet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116092014.GA27945@gradator.net \
--to=sylvain.rochet@finsecur.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).