From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/2] clocksource: don't suspend/resume when unused
Date: Fri, 16 Jan 2015 11:48:04 +0100 [thread overview]
Message-ID: <20150116104804.GE3843@piout.net> (raw)
In-Reply-To: <54B8EA54.5020002@linaro.org>
Hi,
On 16/01/2015 at 11:39:16 +0100, Daniel Lezcano wrote :
> >Isn't that already the case?
> >Right now, if you call clocksource_suspend, it doesn't matter whether
> >the clocksource has an enable or not, it will be suspended. Maybe I'm
> >mistaken but my patch doesn't seem to change that behaviour.
>
> Actually, if there is no enable/disable callback, then CLOCK_SOURCE_USED
> will be never set, hence the condition will always fail and the suspend
> callback won't be called.
>
It is set in clocksource_enable/disable, even if there is no
enable/disable callback. I only found direct calls to ->enable() in
timekeeper.c, did I miss some?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-16 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 9:17 [RFC 0/2] clocksource: don't suspend/resume when unused Alexandre Belloni
2015-01-16 9:17 ` [RFC 1/2] clocksource: track usage Alexandre Belloni
2015-01-16 10:39 ` Boris Brezillon
2015-02-02 20:03 ` Kevin Hilman
2015-01-16 9:17 ` [RFC 2/2] clocksource: don't suspend/resume when unused Alexandre Belloni
2015-01-16 10:23 ` Thomas Gleixner
2015-01-16 10:35 ` Alexandre Belloni
2015-01-16 10:39 ` Daniel Lezcano
2015-01-16 10:48 ` Alexandre Belloni [this message]
2015-01-16 10:59 ` Daniel Lezcano
2015-01-16 11:07 ` Alexandre Belloni
2015-01-16 11:45 ` Alexandre Belloni
2015-01-16 11:23 ` Russell King - ARM Linux
2015-01-16 11:28 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116104804.GE3843@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).