linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: uapi: expose our struct ucontext to the uapi headers
Date: Fri, 16 Jan 2015 15:37:15 +0000	[thread overview]
Message-ID: <20150116153715.GV7091@arm.com> (raw)
In-Reply-To: <20150116153505.GH13634@e104818-lin.cambridge.arm.com>

On Fri, Jan 16, 2015 at 03:35:06PM +0000, Catalin Marinas wrote:
> On Fri, Jan 16, 2015 at 03:26:15PM +0000, Arnd Bergmann wrote:
> > On Friday 16 January 2015 14:47:38 Catalin Marinas wrote:
> > > However,
> > > with the uapi headers change and maybe some additional commits, we end
> > > up copying the uapi/asm-generic/ucontext.h to usr/include/asm/ in the
> > > exported headers which differs from the arch ucontext.h as the latter
> > > was never split in uapi/non-uapi parts (it wasn't in the
> > > arch/arm/include/Kbuild).
> > 
> > Are you sure? When I look at the build/usr/include/asm directory, I
> > only see wrappers like this one
> > 
> > #include <asm-generic/auxvec.h>  // inside usr/include/asm/auxvec.h
> > 
> > and the include/uapi/asm-generic/auxvec.h gets copied to usr/asm-generic/auxvec.h
> > 
> > However, I don't see this wrapper done for the arm or arm64 version
> > of ucontext.h: we get a copy of the generic file in usr/include/asm/ucontext.h
> > but no wrapper for it because arch/arm*/include/uapi/asm/Kbuild does not
> > list ucontext.h.
> 
> I think you are right, maybe I just got confused with
> usr/include/asm-generic/ucontext.h which doesn't matter as user space
> should not include it.

Right; but exporting our own structure is still useful from a userspace
perspective, otherwise they have to follow glibc's lead and define their
own compatible layout.

Will

  reply	other threads:[~2015-01-16 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 13:52 [PATCH] arm64: uapi: expose our struct ucontext to the uapi headers Will Deacon
2015-01-16 14:47 ` Catalin Marinas
2015-01-16 15:26   ` Arnd Bergmann
2015-01-16 15:35     ` Catalin Marinas
2015-01-16 15:37       ` Will Deacon [this message]
2015-01-16 15:38         ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150116153715.GV7091@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).