From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Fri, 16 Jan 2015 16:55:50 -0600 Subject: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq() In-Reply-To: <1421448650-15904-1-git-send-email-tony@atomide.com> References: <1421448650-15904-1-git-send-email-tony@atomide.com> Message-ID: <20150116225550.GA6254@saruman> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 16, 2015 at 02:50:50PM -0800, Tony Lindgren wrote: > Similar to omap_gpio_irq_type() let's make sure that the GPIO > is usable as an interrupt if the platform init code did not > call gpio_request(). Otherwise we can get invalid device access > after setup_irq(): > > WARNING: CPU: 0 PID: 1 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x214/0x340() > 44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4CFG (Idle): Data Access in Supervisor mode during Functional access > ... > [] (__irq_svc) from [] (_raw_spin_unlock_irqrestore+0x34/0x44) > [] (_raw_spin_unlock_irqrestore) from [] (__setup_irq+0x244/0x530) > [] (__setup_irq) from [] (setup_irq+0x40/0x8c) > [] (setup_irq) from [] (omap_system_dma_probe+0x1d4/0x2b4) > [] (omap_system_dma_probe) from [] (platform_drv_probe+0x44/0xa4) > ... > > We can fix this the same way omap_gpio_irq_type() is handling it. > > Note that the long term solution is to change the gpio-omap driver > to handle the banks as separate driver instances. This will allow > us to rely on just runtime PM for tracking the bank specific state. > > Reported-by: Russell King > Cc: Felipe Balbi > Cc: Javier Martinez Canillas > Cc: Kevin Hilman > Cc: Linus Walleij > Cc: Russell King - ARM Linux > Cc: Santosh Shilimkar > Signed-off-by: Tony Lindgren Tony sent me this patch privately for testing, I've boot tested with AM437x IDK, AM437x SK and BBB with CONFIG_PREEMPT. Here are the logs: http://hastebin.com/vabenibema http://hastebin.com/weyukexuzi http://hastebin.com/siceyiwite Tested-by: Felipe Balbi -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: