From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: coh901318: fix function return types build warnings
Date: Sun, 18 Jan 2015 20:02:26 +0530 [thread overview]
Message-ID: <20150118143226.GQ15411@intel.com> (raw)
In-Reply-To: <2760189.hGZZQd3ELS@wuerfel>
On Tue, Jan 13, 2015 at 10:17:03PM +0100, Arnd Bergmann wrote:
> A recent patch that removed coh901318_control() replaced it
> with a number of pointers to existing functions, but those
> unfortunately have the wrong return type and need to be
> changed to return an 'int' with an error value rather than
> a 'void' to avoid these build warnings:
>
> drivers/dma/coh901318.c:2697:32: warning: assignment from incompatible pointer type
> base->dma_slave.device_config = coh901318_dma_set_runtimeconfig;
> ^
> drivers/dma/coh901318.c:2698:31: warning: assignment from incompatible pointer type
> base->dma_slave.device_pause = coh901318_pause;
> ^
> drivers/dma/coh901318.c:2699:32: warning: assignment from incompatible pointer type
> base->dma_slave.device_resume = coh901318_resume
>
> The coh901318_base_init function has the correct return type
> already, but needs to be marked 'static' to avoid a sparse
> warning about a missing declaration.
>
Please use the right subsystem name
Applied now
Thanks
--
~Vinod
prev parent reply other threads:[~2015-01-18 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 21:17 [PATCH] dma: coh901318: fix function return types build warnings Arnd Bergmann
2015-01-14 15:23 ` Linus Walleij
2015-01-18 14:32 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118143226.GQ15411@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).