linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: omap2plus_defconfig:  Enable OHCI & EHCI HCD support
@ 2015-01-19 20:57 Sjoerd Simons
  2015-01-19 21:03 ` Felipe Balbi
  0 siblings, 1 reply; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-19 20:57 UTC (permalink / raw)
  To: linux-arm-kernel

Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
with omap2plus_defconfig.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 arch/arm/configs/omap2plus_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index c2c3a85..295af70 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
 CONFIG_USB_ALI_M5632=y
 CONFIG_USB_AN2720=y
 CONFIG_USB_EPSON2888=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
 CONFIG_USB_KC2190=y
 CONFIG_LIBERTAS=m
 CONFIG_LIBERTAS_USB=m
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support
  2015-01-19 20:57 [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support Sjoerd Simons
@ 2015-01-19 21:03 ` Felipe Balbi
  2015-01-19 21:08   ` Felipe Balbi
  0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2015-01-19 21:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 19, 2015 at 09:57:26PM +0100, Sjoerd Simons wrote:
> Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
> with omap2plus_defconfig.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  arch/arm/configs/omap2plus_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index c2c3a85..295af70 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
>  CONFIG_USB_ALI_M5632=y
>  CONFIG_USB_AN2720=y
>  CONFIG_USB_EPSON2888=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y

should be modules as they break PM.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/b32a1e52/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support
  2015-01-19 21:03 ` Felipe Balbi
@ 2015-01-19 21:08   ` Felipe Balbi
  2015-01-19 21:21     ` Sjoerd Simons
  0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2015-01-19 21:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 19, 2015 at 03:03:41PM -0600, Felipe Balbi wrote:
> On Mon, Jan 19, 2015 at 09:57:26PM +0100, Sjoerd Simons wrote:
> > Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
> > with omap2plus_defconfig.
> > 
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > ---
> >  arch/arm/configs/omap2plus_defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index c2c3a85..295af70 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
> >  CONFIG_USB_ALI_M5632=y
> >  CONFIG_USB_AN2720=y
> >  CONFIG_USB_EPSON2888=y
> > +CONFIG_USB_EHCI_HCD=y
> > +CONFIG_USB_OHCI_HCD=y
> 
> should be modules as they break PM.

oh, and when resending, please add linux-omap to Cc, that's listed in
MAINTAINERS.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/2e1fb26b/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: omap2plus_defconfig:  Enable OHCI & EHCI HCD support
  2015-01-19 21:08   ` Felipe Balbi
@ 2015-01-19 21:21     ` Sjoerd Simons
  2015-01-19 21:41       ` Felipe Balbi
  0 siblings, 1 reply; 6+ messages in thread
From: Sjoerd Simons @ 2015-01-19 21:21 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, 2015-01-19 at 15:08 -0600, Felipe Balbi wrote:
> On Mon, Jan 19, 2015 at 03:03:41PM -0600, Felipe Balbi wrote:
> > On Mon, Jan 19, 2015 at 09:57:26PM +0100, Sjoerd Simons wrote:
> > > Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
> > > with omap2plus_defconfig.
> > > 
> > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > > ---
> > >  arch/arm/configs/omap2plus_defconfig | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > index c2c3a85..295af70 100644
> > > --- a/arch/arm/configs/omap2plus_defconfig
> > > +++ b/arch/arm/configs/omap2plus_defconfig
> > > @@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
> > >  CONFIG_USB_ALI_M5632=y
> > >  CONFIG_USB_AN2720=y
> > >  CONFIG_USB_EPSON2888=y
> > > +CONFIG_USB_EHCI_HCD=y
> > > +CONFIG_USB_OHCI_HCD=y
> > 
> > should be modules as they break PM.
> 
> oh, and when resending, please add linux-omap to Cc, that's listed in
> MAINTAINERS.

Hrm,

Seems like MAINTAINERS is missing an entry to make get_maintainer.pl
recognize linux-omap should be cc'd:

$ ./scripts/get_maintainer.pl -f arch/arm/configs/omap2plus_defconfig
Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
Tony Lindgren <tony@atomide.com>
(commit_signer:23/24=96%,authored:10/24=42%,added_lines:74/107=69%,removed_lines:21/24=88%)
Felipe Balbi <balbi@ti.com>
(commit_signer:7/24=29%,authored:5/24=21%,added_lines:22/107=21%)
Arnd Bergmann <arnd@arndb.de> (commit_signer:6/24=25%)
Nishanth Menon <nm@ti.com> (commit_signer:2/24=8%)
linux-arm-kernel at lists.infradead.org (moderated list:ARM PORT)
linux-kernel at vger.kernel.org (open list)

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/e66a6ddd/attachment-0001.bin>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support
  2015-01-19 21:21     ` Sjoerd Simons
@ 2015-01-19 21:41       ` Felipe Balbi
  2015-01-19 21:50         ` Tony Lindgren
  0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2015-01-19 21:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Mon, Jan 19, 2015 at 10:21:15PM +0100, Sjoerd Simons wrote:
> On Mon, 2015-01-19 at 15:08 -0600, Felipe Balbi wrote:
> > On Mon, Jan 19, 2015 at 03:03:41PM -0600, Felipe Balbi wrote:
> > > On Mon, Jan 19, 2015 at 09:57:26PM +0100, Sjoerd Simons wrote:
> > > > Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
> > > > with omap2plus_defconfig.
> > > > 
> > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > > > ---
> > > >  arch/arm/configs/omap2plus_defconfig | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > > index c2c3a85..295af70 100644
> > > > --- a/arch/arm/configs/omap2plus_defconfig
> > > > +++ b/arch/arm/configs/omap2plus_defconfig
> > > > @@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
> > > >  CONFIG_USB_ALI_M5632=y
> > > >  CONFIG_USB_AN2720=y
> > > >  CONFIG_USB_EPSON2888=y
> > > > +CONFIG_USB_EHCI_HCD=y
> > > > +CONFIG_USB_OHCI_HCD=y
> > > 
> > > should be modules as they break PM.
> > 
> > oh, and when resending, please add linux-omap to Cc, that's listed in
> > MAINTAINERS.
> 
> Hrm,
> 
> Seems like MAINTAINERS is missing an entry to make get_maintainer.pl
> recognize linux-omap should be cc'd:
> 
> $ ./scripts/get_maintainer.pl -f arch/arm/configs/omap2plus_defconfig
> Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
> Tony Lindgren <tony@atomide.com>
> (commit_signer:23/24=96%,authored:10/24=42%,added_lines:74/107=69%,removed_lines:21/24=88%)
> Felipe Balbi <balbi@ti.com>
> (commit_signer:7/24=29%,authored:5/24=21%,added_lines:22/107=21%)
> Arnd Bergmann <arnd@arndb.de> (commit_signer:6/24=25%)
> Nishanth Menon <nm@ti.com> (commit_signer:2/24=8%)
> linux-arm-kernel at lists.infradead.org (moderated list:ARM PORT)
> linux-kernel at vger.kernel.org (open list)

I'll send a patch (unless Tony wants to do it), thanks for reporting.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150119/a7b6456d/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support
  2015-01-19 21:41       ` Felipe Balbi
@ 2015-01-19 21:50         ` Tony Lindgren
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2015-01-19 21:50 UTC (permalink / raw)
  To: linux-arm-kernel

* Felipe Balbi <balbi@ti.com> [150119 13:45]:
> Hi,
> 
> On Mon, Jan 19, 2015 at 10:21:15PM +0100, Sjoerd Simons wrote:
> > On Mon, 2015-01-19 at 15:08 -0600, Felipe Balbi wrote:
> > > On Mon, Jan 19, 2015 at 03:03:41PM -0600, Felipe Balbi wrote:
> > > > On Mon, Jan 19, 2015 at 09:57:26PM +0100, Sjoerd Simons wrote:
> > > > > Enable CONFIG_USB_EHCI_HCD and CONFIG_USB_OHCI_HCD to get USB supports
> > > > > with omap2plus_defconfig.
> > > > > 
> > > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> > > > > ---
> > > > >  arch/arm/configs/omap2plus_defconfig | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > > > > index c2c3a85..295af70 100644
> > > > > --- a/arch/arm/configs/omap2plus_defconfig
> > > > > +++ b/arch/arm/configs/omap2plus_defconfig
> > > > > @@ -159,6 +159,8 @@ CONFIG_USB_NET_SMSC95XX=y
> > > > >  CONFIG_USB_ALI_M5632=y
> > > > >  CONFIG_USB_AN2720=y
> > > > >  CONFIG_USB_EPSON2888=y
> > > > > +CONFIG_USB_EHCI_HCD=y
> > > > > +CONFIG_USB_OHCI_HCD=y
> > > > 
> > > > should be modules as they break PM.
> > > 
> > > oh, and when resending, please add linux-omap to Cc, that's listed in
> > > MAINTAINERS.
> > 
> > Hrm,
> > 
> > Seems like MAINTAINERS is missing an entry to make get_maintainer.pl
> > recognize linux-omap should be cc'd:
> > 
> > $ ./scripts/get_maintainer.pl -f arch/arm/configs/omap2plus_defconfig
> > Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
> > Tony Lindgren <tony@atomide.com>
> > (commit_signer:23/24=96%,authored:10/24=42%,added_lines:74/107=69%,removed_lines:21/24=88%)
> > Felipe Balbi <balbi@ti.com>
> > (commit_signer:7/24=29%,authored:5/24=21%,added_lines:22/107=21%)
> > Arnd Bergmann <arnd@arndb.de> (commit_signer:6/24=25%)
> > Nishanth Menon <nm@ti.com> (commit_signer:2/24=8%)
> > linux-arm-kernel at lists.infradead.org (moderated list:ARM PORT)
> > linux-kernel at vger.kernel.org (open list)
> 
> I'll send a patch (unless Tony wants to do it), thanks for reporting.

Thanks for resending, I'll have a bit hard time tracking patches unless
linux-omap is in Cc.

Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-01-19 21:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-19 20:57 [PATCH] ARM: omap2plus_defconfig: Enable OHCI & EHCI HCD support Sjoerd Simons
2015-01-19 21:03 ` Felipe Balbi
2015-01-19 21:08   ` Felipe Balbi
2015-01-19 21:21     ` Sjoerd Simons
2015-01-19 21:41       ` Felipe Balbi
2015-01-19 21:50         ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).