linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: imx6sx-sdb: change default board as reva board
Date: Tue, 20 Jan 2015 16:03:39 +0800	[thread overview]
Message-ID: <20150120080338.GW2766@dragon> (raw)
In-Reply-To: <BN1PR0301MB062873E37C225DD38B2BCE3CFF4B0@BN1PR0301MB0628.namprd03.prod.outlook.com>

On Tue, Jan 20, 2015 at 07:51:31AM +0000, Anson.Huang at freescale.com wrote:
> > > > +&cpu0 {
> > > > +	operating-points = <
> > > > +		/* kHz    uV */
> > > > +		996000  1250000
> > > > +		792000  1175000
> > > > +		396000  1075000
> > > > +	>;
> > > > +	fsl,soc-operating-points = <
> > > > +		/* ARM kHz  SOC uV */
> > > > +		996000      1175000
> > > > +		792000      1175000
> > > > +		396000      1175000
> > > > +	>;
> > >
> > > I'm wondering why different revision of the board require a different
> > > OPP settings.
> > >
> > 
> > Anson, do you know the reason?
> 
> As i.MX6SX SDB Rev-B board uses PFuse 200 which has only one power supply for both
> VDDARM_IN and VDDSOC_IN, so it needs VDDARM_IN equal VDDSOC_IN, currently
> we set Rev-B board as default in imx6sx.dtsi, which uses same voltage for both
> VDDARM_IN and VDDSOC_IN.The Rev-A board uses PFuze 100 which has separate power
> supply for VDDARM_IN and VDDSOC_IN, so it can use different voltage on VDDARM_IN
> and VDDSOC_IN according to datasheet.

Thanks for the clarification, Anson.

Peter,

OPP is a CPU characteristic defined by data sheet, so we should define
OPP according to data sheet in imx6sx.dtsi, and only overwrite the
property in Rev-B dts per board/PMIC quirk.

Also, please put the rationale why we need OPP quick on Rev-B into
commit log.

Shawn

  reply	other threads:[~2015-01-20  8:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14  7:36 [PATCH 0/2] ARM: imx6sx-sdb: add revb board Peter Chen
2015-01-14  7:36 ` [PATCH 1/2] ARM: imx6sx-sdb: change default board as reva board Peter Chen
2015-01-20  7:35   ` Shawn Guo
2015-01-20  6:30     ` Peter Chen
2015-01-20  7:51       ` Anson.Huang at freescale.com
2015-01-20  8:03         ` Shawn Guo [this message]
2015-01-14  7:36 ` [PATCH 2/2] ARM: imx6sx-sdb: add revb board Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120080338.GW2766@dragon \
    --to=shawn.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).