linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH] arm: omap: hwmod: add debugfs interface
Date: Tue, 20 Jan 2015 09:11:44 -0600	[thread overview]
Message-ID: <20150120151144.GD6556@saruman> (raw)
In-Reply-To: <20150120143603.GB6556@saruman>

On Tue, Jan 20, 2015 at 08:36:03AM -0600, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Jan 20, 2015 at 08:13:57AM +0000, Paul Walmsley wrote:
> > On Tue, 20 Jan 2015, Paul Walmsley wrote:
> > 
> > > On Fri, 5 Dec 2014, Felipe Balbi wrote:
> > > 
> > > > By exposing the details of hwmod structures
> > > > to debugfs we can much more easily verify
> > > > that changes to hwmod data is correct and won't
> > > > cause regressions.
> > > > 
> > > > The idea is that this can be used to check the
> > > > state of one hwmod, verify hwmod sysc fields, etc.
> > > > 
> > > > For example, this will be used to move some of
> > > > the sysc fields to DT and later verify that they
> > > > are correct pre- and post-patch.
> > > > 
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > > 
> > > This one had a bunch of unnecessary includes and checkpatch issues 
> > > (below).  I cleaned those up here and have queued the result (also below) 
> > > for v3.20.
> > 
> > ... and, the patch doesn't even boot.  Dropped.
> > 
> > If you really want something like this to be merged, resend a version that 
> > boots, and has checkpatch warnings fixed and unnecessary includes dropped.  
> > Otherwise you're just wasting my time.
> 
> you're using a really old version, though. There have been other
> versions which are still under discussion.

not to mention that this was an RFC, not meant for merging at the time
it was sent.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150120/d50f40c9/attachment.sig>

      reply	other threads:[~2015-01-20 15:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 22:31 [RFC/PATCH] arm: omap: hwmod: add debugfs interface Felipe Balbi
2015-01-20  5:18 ` Paul Walmsley
2015-01-20  8:13   ` Paul Walmsley
2015-01-20 14:36     ` Felipe Balbi
2015-01-20 15:11       ` Felipe Balbi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120151144.GD6556@saruman \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).