From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: early fixmap support for earlycon
Date: Tue, 20 Jan 2015 23:48:21 +0000 [thread overview]
Message-ID: <20150120234821.GN26493@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1421797064-2989-1-git-send-email-stefan@agner.ch>
On Wed, Jan 21, 2015 at 12:37:44AM +0100, Stefan Agner wrote:
> Add early fixmap support, initially to support permanent, fixed
> mapping support for early console. A temporary, early pte is
> created which is migrated to a permanent mapping in paging_init.
> This is also needed since the attributs may change as the memory
> types are initialized. The 3MiB range of fixmap spans two pte
> tables, but currently only one pte is created for early fixmap
> support.
I think this needs to be done more carefully - I think the entry(ies)
should be removed, the TLBs flushed, and the new entry established.
So:
> +static void __init early_fixmap_shutdown(void)
> +{
> + int i;
> +
> + pte_offset_fixmap = &pte_offset_late_fixmap;
> + pmd_clear(fixmap_pmd(fix_to_virt(__end_of_permanent_fixed_addresses - 1)));
I think you should flush tlbs here.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-01-20 23:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 23:37 [PATCH v2] ARM: early fixmap support for earlycon Stefan Agner
2015-01-20 23:48 ` Russell King - ARM Linux [this message]
2015-01-21 8:59 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120234821.GN26493@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).