Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ideal.song@samsung.com (Inha Song)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes
Date: Thu, 22 Jan 2015 10:01:30 +0900	[thread overview]
Message-ID: <20150122100130.75c20e9b@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <54BF9083.5090708@samsung.com>

Hi,

Thanks for your comment.

On Wed, 21 Jan 2015 12:41:55 +0100
Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:

> Hi,
> 
> On 21/01/15 06:58, Inha Song wrote:
> > Add MAX98090 audio codec, I2S interface and the sound nodes to support
> > audio on Odroid-XU3 board.
> > 
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 34 ++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > index 7874da2..79493d1 100644
> > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> > @@ -310,6 +310,40 @@
> >  	rtc at 101E0000 {
> >  		status = "okay";
> >  	};
> > +
> > +	sound: sound {
> > +		compatible = "samsung,odroidu3-audio";
> 
> How about using simple-card instead ? I've been trying to switch
> Odroid X2/U3 to simple card. Here a corresponding dts patch:
> http://www.spinics.net/lists/linux-samsung-soc/msg41083.html
> For that recent patches for the I2S driver which area already in -next
> might be needed.

Oh, I missed your patchs.
I will rework this patch based on your patch.

Best Regards,
Inha Song.

> 
> > +		samsung,model = "Odroid-XU3";
> > +		samsung,i2s-controller = <&i2s0>;
> > +		samsung,audio-codec = <&max98090>;
> > +		assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> > +				  <&clock_audss EXYNOS_MOUT_I2S>;
> > +		assigned-clock-parents = <&clock CLK_FIN_PLL>,
> > +				<&clock_audss EXYNOS_MOUT_AUDSS>;
> > +		samsung,audio-routing =
> > +			"Headphone Jack", "HPL",
> > +			"Headphone Jack", "HPR",
> > +			"Headphone Jack", "MICBIAS",
> > +			"IN1", "Headphone Jack",
> > +			"Speakers", "SPKL",
> > +			"Speakers", "SPKR";
> > +	};
> > +};
> > +
> > +&hsi2c_5 {
> > +	status = "okay";
> > +	max98090: max98090 at 10 {
> > +		compatible = "maxim,max98090";
> > +		reg = <0x10>;
> > +		interrupt-parent = <&gpx3>;
> > +		interrupts = <2 0>;
> > +		clocks = <&clock_audss EXYNOS_DOUT_AUD_BUS>;
> > +		clock-names = "mclk";
> > +	};
> > +};
> 
> -- 
> Thanks,
> Sylwester

      reply	other threads:[~2015-01-22  1:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  5:58 [PATCH] ARM: dts: exynos5422-odroidxu3: add sound nodes Inha Song
2015-01-21 11:41 ` Sylwester Nawrocki
2015-01-22  1:01   ` Inha Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150122100130.75c20e9b@songinha-Samsung-DeskTop-System \
    --to=ideal.song@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox