linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()
Date: Thu, 22 Jan 2015 15:25:23 -0500	[thread overview]
Message-ID: <20150122202523.GC5813@l.oracle.com> (raw)
In-Reply-To: <1421800225-26230-4-git-send-email-wangyijing@huawei.com>

On Wed, Jan 21, 2015 at 08:29:58AM +0800, Yijing Wang wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Use pci_scan_root_bus() instead of deprecated function
> pci_scan_bus_parented().
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: xen-devel at lists.xenproject.org

It looks OK to me thought I need to test it first.
> ---
>  drivers/pci/xen-pcifront.c |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index b1ffebe..240ddbc 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -446,6 +446,7 @@ static int pcifront_scan_root(struct pcifront_device *pdev,
>  				 unsigned int domain, unsigned int bus)
>  {
>  	struct pci_bus *b;
> +	LIST_HEAD(resources);
>  	struct pcifront_sd *sd = NULL;
>  	struct pci_bus_entry *bus_entry = NULL;
>  	int err = 0;
> @@ -470,17 +471,20 @@ static int pcifront_scan_root(struct pcifront_device *pdev,
>  		err = -ENOMEM;
>  		goto err_out;
>  	}
> +	pci_add_resource(&resources, &ioport_resource);
> +	pci_add_resource(&resources, &iomem_resource);
>  	pcifront_init_sd(sd, domain, bus, pdev);
>  
>  	pci_lock_rescan_remove();
>  
> -	b = pci_scan_bus_parented(&pdev->xdev->dev, bus,
> -				  &pcifront_bus_ops, sd);
> +	b = pci_scan_root_bus(&pdev->xdev->dev, bus,
> +				  &pcifront_bus_ops, sd, &resources);
>  	if (!b) {
>  		dev_err(&pdev->xdev->dev,
>  			"Error creating PCI Frontend Bus!\n");
>  		err = -ENOMEM;
>  		pci_unlock_rescan_remove();
> +		pci_free_resource_list(&resources);
>  		goto err_out;
>  	}
>  
> @@ -488,7 +492,7 @@ static int pcifront_scan_root(struct pcifront_device *pdev,
>  
>  	list_add(&bus_entry->list, &pdev->root_buses);
>  
> -	/* pci_scan_bus_parented skips devices which do not have a have
> +	/* pci_scan_root_bus skips devices which do not have a have
>  	* devfn==0. The pcifront_scan_bus enumerates all devfn. */
>  	err = pcifront_scan_bus(pdev, domain, bus, b);
>  
> -- 
> 1.7.1
> 

  reply	other threads:[~2015-01-22 20:25 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  0:29 [PATCH v2 00/30] Refine PCI scan interfaces and make generic pci host bridge Yijing Wang
2015-01-21  0:29 ` [PATCH v2 01/30] PCI: Rip out pci_bus_add_devices() from pci_scan_bus() Yijing Wang
2015-01-21  0:29 ` [PATCH v2 02/30] PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus() Yijing Wang
2015-01-21  0:29 ` [PATCH v2 03/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented() Yijing Wang
2015-01-22 20:25   ` Konrad Rzeszutek Wilk [this message]
2015-01-23  2:12     ` Yijing Wang
2015-01-21  0:29 ` [PATCH v2 04/30] PCI: Remove deprecated pci_scan_bus_parented() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 05/30] PCI: Rename pci_scan_bus() to pci_scan_bus_legacy() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 06/30] PCI: Combine PCI domain and bus number in u32 arg Yijing Wang
2015-01-21  0:30 ` [PATCH v2 07/30] PCI: Pass PCI domain number combined with root bus number Yijing Wang
2015-01-21  0:30 ` [PATCH v2 08/30] PCI: Introduce pci_host_assign_domain_nr() to assign domain Yijing Wang
2015-01-21  0:30 ` [PATCH v2 09/30] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 10/30] PCI: Introduce pci_host_bridge_list to manage host bridges Yijing Wang
2015-01-21  0:30 ` [PATCH v2 11/30] PCI: Save sysdata in pci_host_bridge drvdata Yijing Wang
2015-01-21  0:30 ` [PATCH v2 12/30] PCI: Introduce pci_host_bridge_ops to support host specific operations Yijing Wang
2015-01-21  0:30 ` [PATCH v2 13/30] PCI: Introduce new scan function pci_scan_root_bridge() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 14/30] PCI/x86: Refine pci_acpi_scan_root() with generic pci_host_bridge Yijing Wang
2015-01-21  0:30 ` [PATCH v2 15/30] PCI/IA64: " Yijing Wang
2015-01-21  0:30 ` [PATCH v2 16/30] PCI/IA64: Fix the build warning about pci_domain_nr() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 17/30] PCI/powerpc: Rename pcibios_root_bridge_prepare() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 18/30] PCI/powerpc: Use pci_scan_root_bridge() for simplicity Yijing Wang
2015-01-21  0:30 ` [PATCH v2 19/30] PCI: Remove weak pcibios_root_bridge_prepare() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 20/30] PCI/sparc: Use pci_scan_root_bridge() for simplicity Yijing Wang
2015-01-21  0:30 ` [PATCH v2 21/30] PCI: Introduce pci_bus_child_max_busnr() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 22/30] PCI/Parisc: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-01-21  0:30 ` [PATCH v2 23/30] PCI/mvebu: Use pci_common_init_dev() to simplify code Yijing Wang
2015-01-22 17:40   ` Thomas Petazzoni
2015-01-23  2:11     ` Yijing Wang
2015-02-16 17:46     ` Lorenzo Pieralisi
2015-01-21  0:30 ` [PATCH v2 24/30] PCI/tegra: Remove redundant tegra_pcie_scan_bus() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 25/30] PCI/designware: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-01-21  0:30 ` [PATCH v2 26/30] PCI/xgene: Use pci_scan_root_bus() instead of pci_create_root_bus() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 27/30] PCI: Rename __pci_create_root_bus() to pci_create_root_bus() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 28/30] PCI: Export find_pci_host_bridge() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 29/30] PCI: Remove platform specific pci_domain_nr() Yijing Wang
2015-01-21  0:30 ` [PATCH v2 30/30] PCI: Remove pci_bus_assign_domain_nr() Yijing Wang
2015-01-30  9:10 ` [PATCH v2 00/30] Refine PCI scan interfaces and make generic pci host bridge Yijing Wang
2015-01-30 15:45   ` Bjorn Helgaas
2015-01-31  0:55     ` Yijing Wang
2015-02-14 19:45 ` Lorenzo Pieralisi
2015-02-15  1:11   ` Yijing Wang
2015-02-16  1:18   ` Yijing Wang
2015-02-16  3:13     ` Benjamin Herrenschmidt
2015-02-16  3:28       ` Yijing Wang
2015-02-25 23:09 ` Bjorn Helgaas
2015-02-26  0:54   ` Yijing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150122202523.GC5813@l.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).