From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V2] OPP: Redefine bindings to overcome shortcomings
Date: Fri, 23 Jan 2015 11:52:06 +0000 [thread overview]
Message-ID: <20150123115206.GT21293@sirena.org.uk> (raw)
In-Reply-To: <1422013154.29475.11.camel@pengutronix.de>
On Fri, Jan 23, 2015 at 12:39:14PM +0100, Lucas Stach wrote:
> > + Required properties:
> > + - opp-khz: Frequency in kHz
> > + - opp-microvolt: voltage in micro Volts
> Each OPP voltage should be defined by the triplet of minimum,
> nominal/typical, maximum. This lets you specify exact tolerances in each
> direction and should cover most use-cases.
> IMHO it would make sense to just define opp-microvolt as an array of
> those 3 values, so the DT doesn't get bloated with a lot more
> properties.
> A typical value for a CPU could then look like this:
> opp-microvolt = <800000 850000 1100000>
I tend to agree that this is clearer. It might be nice to have variants
for specifying directly as a percentage but I don't think it's really
worth the complexity.
> For devices without any tolerance you can just specify the same value
> three times and be done with it:
> opp-microvolt = <900000 900000 900000>
If we change the binding to be typ/min/max rather than min/typ/max then
we could also do this by allowing either one or three values to be
specified. That might be more worth the complexity especially given...
> > + Optional properties:
> > + - turbo-mode: Marks the volt-freq pair as turbo pair.
> > + - status: Marks the node enabled/disabled.
> > + - voltage-tolerance: Specify the CPU voltage tolerance in percentage.
> Please let's drop this.
DT bindings are supposed to be stable, this means the code should accept
old bindings and they should be documented as deprecated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150123/949c5193/attachment.sig>
next prev parent reply other threads:[~2015-01-23 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 10:44 [RFC V2] OPP: Redefine bindings to overcome shortcomings Viresh Kumar
2015-01-23 10:46 ` Viresh Kumar
2015-01-23 11:39 ` Lucas Stach
2015-01-23 11:52 ` Mark Brown [this message]
2015-01-23 12:55 ` Viresh Kumar
2015-01-23 12:53 ` Viresh Kumar
2015-01-28 20:06 ` Mark Brown
2015-01-29 1:39 ` Viresh Kumar
2015-01-29 11:07 ` Mark Brown
2015-01-29 11:34 ` Viresh Kumar
2015-01-29 15:42 ` Rob Herring
2015-01-30 5:17 ` Viresh Kumar
2015-01-29 16:22 ` Rob Herring
2015-01-30 5:36 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123115206.GT21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox