From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 26 Jan 2015 11:11:19 +0000 Subject: [PATCH 7/7] mfd: Add support for the MediaTek MT6397 PMIC In-Reply-To: <20150126105222.GM12209@pengutronix.de> References: <1422022202-7526-1-git-send-email-s.hauer@pengutronix.de> <1422022202-7526-8-git-send-email-s.hauer@pengutronix.de> <20150123161440.GA11745@x1> <20150126105222.GM12209@pengutronix.de> Message-ID: <20150126111119.GE11745@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 26 Jan 2015, Sascha Hauer wrote: > On Fri, Jan 23, 2015 at 04:14:40PM +0000, Lee Jones wrote: > > On Fri, 23 Jan 2015, Sascha Hauer wrote: > > > > > From: Flora Fu > > > > > > This adds support for the MediaTek MT6397 PMIC. This is a > > > multifunction device with the following sub modules: > > > > > > - Regulator > > > - RTC > > > - Audio codec > > > - GPIO > > > - Clock > > > > > > It is interfaced to the host controller using SPI interface by a proprietary > > > hardware called PMIC wrapper or pwrap. MT6397 MFD is a child device of the > > > pwrap. > > > > > > Signed-off-by: Flora Fu, MediaTek > > > Signed-off-by: Sascha Hauer > > > Cc: Samuel Ortiz > > > Cc: Lee Jones > > > --- > > > Documentation/devicetree/bindings/mfd/mt6397.txt | 70 +++++ [...] > > > + struct mt6397_chip *mt6397 = irq_get_chip_data(data->irq); > > > + int shift = mt6397_irq_shift(data->hwirq); > > > + int reg = mt6397_irq_reg(data->hwirq); > > > + int reg_ofs = MT6397_INT_CON0 + reg * 2; > > > + > > > + mt6397->irq_masks_cur[reg] &= ~(1 << shift); > > > > s/(1 << shift)/BIT(shift)/ > > Is it mentioned somewhere that these BIT macros shall be used? There are > quadrillions of examples for both styles in the kernel and personally I > think 1 << x is more readable. I haven't seen a hard and fast 'rule' per say. I think it's left up to the Maintainer of any given subsystem. ;) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog