From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: N900 v3.19-rc5 arm atags_to_fdt.c is broken
Date: Mon, 26 Jan 2015 08:14:55 -0800 [thread overview]
Message-ID: <20150126161454.GE28663@atomide.com> (raw)
In-Reply-To: <201501232336.36187@pali>
* Pali Roh?r <pali.rohar@gmail.com> [150123 14:39]:
> On Friday 23 January 2015 22:39:55 Pali Roh?r wrote:
> > Hello,
> >
> > when I boot zImage with appended DT n900 in qemu
> > fdt_open_into() function called from file
> > arch/arm/boot/compressed/atags_to_fdt.c (in function
> > atags_to_fdt) always returns -FDT_ERR_NOSPACE.
> >
> > It means that all ATAGS (including cmdline arguments) passed
> > by bootloader are ignored.
> >
> > On real n900 device I see that booted DT version also ignore
> > cmdline arguments from bootloader. I cannot debug decompress
> > code on real device, but I think it is same problem as in
> > qemu.
>
> Looks like this quick patch is fixing above problem:
>
> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
> index 68be901..4a7d75b 100644
> --- a/arch/arm/boot/compressed/head.S
> +++ b/arch/arm/boot/compressed/head.S
> @@ -268,7 +268,7 @@ restart: adr r0, LC0
> * area. No GOT fixup has occurred yet, but none of the
> * code we're about to call uses any global variable.
> */
> - add sp, sp, #0x10000
> + add sp, sp, #0x20000
> stmfd sp!, {r0-r3, ip, lr}
> mov r0, r8
> mov r1, r6
> @@ -289,7 +289,7 @@ restart: adr r0, LC0
> bleq atags_to_fdt
>
> ldmfd sp!, {r0-r3, ip, lr}
> - sub sp, sp, #0x10000
> + sub sp, sp, #0x20000
> #endif
>
> mov r8, r6 @ use the appended device tree
Nico, got any ideas about this one? This seems like a regression
somewhere..
Regards,
Tony
next prev parent reply other threads:[~2015-01-26 16:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 21:39 N900 v3.19-rc5 arm atags_to_fdt.c is broken Pali Rohár
2015-01-23 22:36 ` Pali Rohár
2015-01-23 23:48 ` Pavel Machek
2015-01-24 9:04 ` Pali Rohár
2015-01-26 16:14 ` Tony Lindgren [this message]
2015-01-26 16:23 ` Pali Rohár
2015-01-26 17:03 ` Tony Lindgren
2015-01-26 18:57 ` Nicolas Pitre
2015-01-26 21:48 ` Pavel Machek
2015-01-27 0:06 ` Nicolas Pitre
2015-01-27 13:37 ` Pavel Machek
2015-01-27 15:16 ` Nicolas Pitre
2015-01-27 15:26 ` Pali Rohár
2015-01-27 15:26 ` Tony Lindgren
2015-01-27 17:53 ` Russell King - ARM Linux
2015-01-27 18:50 ` Nicolas Pitre
2015-01-27 23:09 ` Aaro Koskinen
2015-01-27 23:17 ` Pavel Machek
2015-02-02 13:39 ` Pavel Machek
2015-02-02 13:56 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126161454.GE28663@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).