linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL RESEND] pxa for v3.20
Date: Mon, 26 Jan 2015 18:17:33 -0800	[thread overview]
Message-ID: <20150127021733.GB22154@quad.lixom.net> (raw)
In-Reply-To: <874mrgdzz0.fsf@free.fr>

On Sat, Jan 24, 2015 at 03:18:11PM +0100, Robert Jarzmik wrote:
> Olof Johansson <olof@lixom.net> writes:
> 
> > Hi Robert,
> >
> > Branch looks good, I'll merge this into next/fixes-non-critical. One nit below
> > though:
> >
> >> ----------------------------------------------------------------
> >> Dmitry Eremin-Solenikov (3):
> >>       ARM: pxa: add regulator_has_full_constraints to corgi board file
> >>       ARM: pxa: add regulator_has_full_constraints to poodle board file
> >>       ARM: pxa: add regulator_has_full_constraints to spitz board file
> >> 
> >> Martin Vajnar (1):
> >>       hx4700: regulator: declare full constraints
> >
> > Please use consistent patch subjects in the future. We've ended up using ARM:
> > <platform>: <foo> across all platforms these days.
> >
> > I'm not going to ask you to respin just for this, but please remember to fix
> > future patches when you apply them if they're not already correct.
> You're right, I missed that one.
> 
> In case you've not already pulled, I created :
>    https://github.com/rjarzmik/linux.git tags/pxa-for-3.20-bis
> 
> I can resend a proper pull request if you wish, or we can leave it as is if you
> already pulled. In any case I'll be more carefull next time, maybe I can
> convince my bot to check that for me too.

I had already merged, but it looks like you broke viper and zeus. Both of them
still refer to PXA_ISA_IRQ().

Can you send an incremental patch for that? Or if you prefer that we drop this
branch for now while you sort it out that's OK too -- your preference.

> Or even better checkpatch could check that any patch with a diffstat fully in
> arch/arm/{mach,plat}-<XYZ> has a subject beginning with "ARM: XYZ: ", that would
> be cool, and put the burden on others as well :)

Yeah we normally scale this by educating downstream maintainers. checkpatch is
useful in many cases but making it do everything is hard.


-Olof

  reply	other threads:[~2015-01-27  2:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 19:01 [GIT PULL RESEND] pxa for v3.20 Robert Jarzmik
2015-01-23 21:54 ` Olof Johansson
2015-01-24 14:18   ` Robert Jarzmik
2015-01-27  2:17     ` Olof Johansson [this message]
2015-01-27  4:42       ` Robert Jarzmik
2015-01-27  4:45         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127021733.GB22154@quad.lixom.net \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).