From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: N900 v3.19-rc5 arm atags_to_fdt.c is broken
Date: Tue, 27 Jan 2015 16:26:12 +0100 [thread overview]
Message-ID: <201501271626.12365@pali> (raw)
In-Reply-To: <alpine.LFD.2.11.1501271014160.1322@knanqh.ubzr>
On Tuesday 27 January 2015 16:16:24 Nicolas Pitre wrote:
> On Tue, 27 Jan 2015, Pavel Machek wrote:
> > > > > I would say, problem is because omap3-n900 binary DT
> > > > > is too large
> > >
> > > I agree.
> > >
> > > > OK if that's the case, then your patch makes sense to
> > > > me. It also seems we can have the temporary stack be
> > > > larger than the initial stack just for atags_to_fdt.
> > >
> > > The stack size isn't the issue, but rather its location.
> > > We need to position it away from the DT data. The DT
> > > size is known and we could use that, plus some room for
> > > the insertion of new data coming from the ATAG
> > > conversion.
> >
> > > Something like the following would be a more robust
solution:
> > Tested-by: Pavel Machek <pavel@ucw.cz>
> >
> > (Note, that in 3.19 dts for n900 got too big, so we are
> > actually triggering old bugs. That means that this is a
> > regression fix, and should go in ASAP).
>
> It is queued here:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id
> =8294/1
>
>
> Nicolas
I tested your patch and fdt_open_into() does not return error
FDT_ERR_NOSPACE anymore. It is working. So you can add my
Tested-by: Pali Roh?r <pali.rohar@gmail.com>
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150127/8da05adc/attachment.sig>
next prev parent reply other threads:[~2015-01-27 15:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 21:39 N900 v3.19-rc5 arm atags_to_fdt.c is broken Pali Rohár
2015-01-23 22:36 ` Pali Rohár
2015-01-23 23:48 ` Pavel Machek
2015-01-24 9:04 ` Pali Rohár
2015-01-26 16:14 ` Tony Lindgren
2015-01-26 16:23 ` Pali Rohár
2015-01-26 17:03 ` Tony Lindgren
2015-01-26 18:57 ` Nicolas Pitre
2015-01-26 21:48 ` Pavel Machek
2015-01-27 0:06 ` Nicolas Pitre
2015-01-27 13:37 ` Pavel Machek
2015-01-27 15:16 ` Nicolas Pitre
2015-01-27 15:26 ` Pali Rohár [this message]
2015-01-27 15:26 ` Tony Lindgren
2015-01-27 17:53 ` Russell King - ARM Linux
2015-01-27 18:50 ` Nicolas Pitre
2015-01-27 23:09 ` Aaro Koskinen
2015-01-27 23:17 ` Pavel Machek
2015-02-02 13:39 ` Pavel Machek
2015-02-02 13:56 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501271626.12365@pali \
--to=pali.rohar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox