From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/13] pm: at91: move the copying the sram function to the sram initializationi phase
Date: Thu, 29 Jan 2015 11:28:00 +0000 [thread overview]
Message-ID: <20150129112800.GV26493@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1422409396-24394-1-git-send-email-wenyou.yang@atmel.com>
On Wed, Jan 28, 2015 at 09:43:16AM +0800, Wenyou Yang wrote:
> -#ifdef CONFIG_AT91_SLOW_CLOCK
> - /* copy slow_clock handler to SRAM, and call it */
> - memcpy(slow_clock, at91_slow_clock, at91_slow_clock_sz);
> -#endif
> slow_clock(at91_pmc_base, at91_ramc_base[0],
> at91_ramc_base[1],
> at91_pm_data.memctrl);
> @@ -272,6 +268,9 @@ static void __init at91_pm_sram_init(void)
> sram_pbase = gen_pool_virt_to_phys(sram_pool, sram_base);
> slow_clock = __arm_ioremap_exec(sram_pbase, at91_slow_clock_sz, false);
>
> + /* Copy the slow_clock handler to SRAM */
> + memcpy(slow_clock, at91_slow_clock, at91_slow_clock_sz);
> +
Why is this code not using the fncpy() support for copying functions.
Why is it not checking the return code from __arm_ioremap_exec() or
gen_pool_virt_to_phys() for failure?
This looks like quite a massive review failure when this code was
originally merged. It needs fixing.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-01-29 11:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 1:39 [PATCH v4 00/13] AT91 pm cleanup for 3.20 Wenyou Yang
2015-01-28 1:40 ` [PATCH v4 01/13] pm: at91: pm_slowclock: fix suspend/resume hang up in timeouts Wenyou Yang
2015-01-28 1:41 ` [PATCH v4 02/13] pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode Wenyou Yang
2015-01-28 1:41 ` [PATCH v4 03/13] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories Wenyou Yang
2015-01-28 1:42 ` [PATCH v4 04/13] pm: at91: pm_slowclock: remove the unused code related with SLOWDOWN_MASTER_CLOCK Wenyou Yang
2015-01-28 1:43 ` [PATCH v4 05/13] pm: at91: move the copying the sram function to the sram initializationi phase Wenyou Yang
2015-01-29 11:28 ` Russell King - ARM Linux [this message]
2015-01-29 15:09 ` Alexandre Belloni
2015-01-30 7:03 ` Yang, Wenyou
2015-01-30 6:59 ` Yang, Wenyou
2015-01-30 10:16 ` Russell King - ARM Linux
2015-01-28 1:43 ` [PATCH v4 06/13] ARM: at91: move select SRAM to ARCH_AT91 Wenyou Yang
2015-01-28 1:44 ` [PATCH v4 07/13] pm: at91: remove the config item CONFIG_AT91_SLOW_CLOCK Wenyou Yang
2015-01-28 1:45 ` [PATCH v4 08/13] pm: at91: the standby mode uses the same sram function as the suspend to memory mode Wenyou Yang
2015-01-28 1:46 ` [PATCH v4 09/13] pm: at91: rename file name: pm_slowclock.S -->pm_suspend.S Wenyou Yang
2015-01-28 1:46 ` [PATCH v4 10/13] pm: at91: rename function name: at91_slow_clock()-->at91_pm_suspend_sram_fn Wenyou Yang
2015-01-28 1:47 ` [PATCH v4 11/13] pm: at91: remove the at91_xxx_standby() function definitions in the pm.h Wenyou Yang
2015-01-28 1:48 ` [PATCH v4 12/13] pm: at91: setup: remove the struct ramc_ids .data at91_xxx_standby members Wenyou Yang
2015-01-28 1:48 ` [PATCH v4 13/13] pm: at91: amend the pm_suspend entry for at91_cpuidle_device Wenyou Yang
2015-01-28 8:59 ` [PATCH v4 00/13] AT91 pm cleanup for 3.20 Sylvain Rochet
2015-01-28 9:06 ` Sylvain Rochet
2015-01-28 9:12 ` Yang, Wenyou
2015-01-28 9:14 ` [PATCH v4 00/13 RESEND] " Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129112800.GV26493@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).