From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: moxart: fix probe logic
Date: Thu, 29 Jan 2015 17:01:04 +0000 [thread overview]
Message-ID: <20150129170104.GD26493@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <8340872.32GezMfzR1@wuerfel>
On Thu, Jan 29, 2015 at 05:15:31PM +0100, Arnd Bergmann wrote:
> @@ -586,10 +586,10 @@ static int moxart_probe(struct platform_device *pdev)
> goto out;
> }
>
> - clk = of_clk_get(node, 0);
> - if (IS_ERR(clk)) {
> + host->clk = of_clk_get(node, 0);
> + if (IS_ERR(host->clk)) {
> dev_err(dev, "of_clk_get failed\n");
> - ret = PTR_ERR(clk);
> + ret = PTR_ERR(host->clk);
> goto out;
> }
>
...
> @@ -677,6 +679,8 @@ static int moxart_probe(struct platform_device *pdev)
> return 0;
>
> out:
> + if (host->clk)
> + clk_put(host->clk);
Are you sure?
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-01-29 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 16:15 [PATCH] mmc: moxart: fix probe logic Arnd Bergmann
2015-01-29 17:01 ` Russell King - ARM Linux [this message]
2015-01-29 22:04 ` Arnd Bergmann
2015-01-29 22:06 ` [PATCH v2] " Arnd Bergmann
2015-02-02 10:52 ` Jonas Jensen
2015-02-02 14:58 ` Arnd Bergmann
2015-02-02 15:43 ` [PATCH v3] " Jonas Jensen
2015-02-02 20:03 ` Arnd Bergmann
2015-02-03 15:55 ` [PATCH v4] " Jonas Jensen
2015-02-04 8:40 ` Ulf Hansson
2015-02-03 8:02 ` [PATCH v3] " Ulf Hansson
2015-02-03 9:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150129170104.GD26493@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).