linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Tue, 03 Feb 2015 13:08:49 -0800	[thread overview]
Message-ID: <20150203210849.421.54288@quantum> (raw)
In-Reply-To: <CAOMZO5CTaqzs2bwXL4V9boMSjOw6TcGBLXe9U=9-wEvwfvGYeQ@mail.gmail.com>

Quoting Fabio Estevam (2015-01-30 11:28:32)
> On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional
> > clock control register is 32-bit wide, but is separated in 4 parts.
> > So write instructions must not apply to more than 1 part at once.
> >
> > The clk init for the i.MX28 violates this restriction and all the other
> > accesses on that register suggest that there isn't such a restriction.
> >
> > This patch restricts the access to this register to byte instructions and
> > extends the comment in the init functions.
> >
> > Btw the imx23 init now uses a R-M-W sequence just like imx28 init
> > to avoid any clock glitches.
> >
> > The changes has been tested with a i.MX23 and a i.MX28 board.
> >
> > [1] - http://cache.freescale.com/files/dsp/doc/ref_manual/IMX23RM.pdf
> > [2] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > Reviewed-by: Marek Vasut <marex@denx.de>
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied to clk-next.

Thanks,
Mike

> 
> Thanks

  reply	other threads:[~2015-02-03 21:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30 19:20 [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers Stefan Wahren
2015-01-30 19:28 ` Fabio Estevam
2015-02-03 21:08   ` Mike Turquette [this message]
2015-02-10 12:52 ` Fabio Estevam
2015-02-10 13:05   ` Stefan Wahren
2015-02-10 13:09     ` Fabio Estevam
2015-02-10 13:55       ` Stefan Wahren
2015-02-10 15:06         ` Fabio Estevam
2015-02-10 21:24           ` Stefan Wahren
2015-02-10 21:54             ` Fabio Estevam
2015-02-10 22:07               ` Marek Vasut
2015-02-11  2:24                 ` Mike Turquette
2015-02-11 16:58             ` Fabio Estevam
2015-02-11 20:31               ` Stefan Wahren
2015-02-11 21:10                 ` Fabio Estevam
2015-02-12 18:59                   ` Stefan Wahren
2015-02-12 19:08                     ` Fabio Estevam
2015-02-16 20:24                       ` Stefan Wahren
2015-02-17  8:09                         ` Marek Vasut
2015-02-20 11:09                 ` Stefan Wahren
  -- strict thread matches above, loose matches on Subject: below --
2015-01-30 19:14 Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203210849.421.54288@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).