From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Tue, 03 Feb 2015 13:08:49 -0800 Subject: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers In-Reply-To: References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> Message-ID: <20150203210849.421.54288@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Fabio Estevam (2015-01-30 11:28:32) > On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: > > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional > > clock control register is 32-bit wide, but is separated in 4 parts. > > So write instructions must not apply to more than 1 part at once. > > > > The clk init for the i.MX28 violates this restriction and all the other > > accesses on that register suggest that there isn't such a restriction. > > > > This patch restricts the access to this register to byte instructions and > > extends the comment in the init functions. > > > > Btw the imx23 init now uses a R-M-W sequence just like imx28 init > > to avoid any clock glitches. > > > > The changes has been tested with a i.MX23 and a i.MX28 board. > > > > [1] - http://cache.freescale.com/files/dsp/doc/ref_manual/IMX23RM.pdf > > [2] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf > > > > Signed-off-by: Stefan Wahren > > Reviewed-by: Marek Vasut > > Reviewed-by: Fabio Estevam Applied to clk-next. Thanks, Mike > > Thanks