From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvain.rochet@finsecur.com (Sylvain Rochet) Date: Mon, 9 Feb 2015 19:26:06 +0100 Subject: [PATCH v2] drm: atmel-hlcdc: Atomic mode-setting conversion In-Reply-To: <1423236143-6494-1-git-send-email-boris.brezillon@free-electrons.com> References: <1423236143-6494-1-git-send-email-boris.brezillon@free-electrons.com> Message-ID: <20150209182606.GA11712@gradator.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Boris, On Fri, Feb 06, 2015 at 04:22:23PM +0100, Boris Brezillon wrote: > Convert the HLCDC driver to atomic mode-setting. > > Signed-off-by: Boris Brezillon > --- I am getting the following trace with this patch applied, which seems pretty straightforward to fix. Apart from that, it works perfectly, you can add my: Tested-by: Sylvain Rochet ------------[ cut here ]------------ WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:992 clk_disable+0x28/0x34() Modules linked in: CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 3.19.0-rc7-next-20150204+ #90 Hardware name: Atmel SAMA5 (Device Tree) Workqueue: events output_poll_execute [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (warn_slowpath_common+0x84/0xb0) [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) [] (warn_slowpath_null) from [] (clk_disable+0x28/0x34) [] (clk_disable) from [] (atmel_hlcdc_crtc_disable+0xe8/0x114) [] (atmel_hlcdc_crtc_disable) from [] (__drm_helper_disable_unused_functions+0xa4/0xd8) [] (__drm_helper_disable_unused_functions) from [] (drm_helper_disable_unused_functions+0x14/0x20) [] (drm_helper_disable_unused_functions) from [] (drm_fbdev_cma_init+0x78/0xfc) [] (drm_fbdev_cma_init) from [] (atmel_hlcdc_fb_output_poll_changed+0x30/0x40) [] (atmel_hlcdc_fb_output_poll_changed) from [] (output_poll_execute+0x148/0x188) [] (output_poll_execute) from [] (process_one_work+0xfc/0x310) [] (process_one_work) from [] (worker_thread+0x60/0x478) [] (worker_thread) from [] (kthread+0xd4/0xec) [] (kthread) from [] (ret_from_fork+0x14/0x34) ---[ end trace 9500ebf8d7076b60 ]--- ------------[ cut here ]------------ WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:898 clk_unprepare+0x24/0x2c() Modules linked in: CPU: 0 PID: 9 Comm: kworker/0:1 Tainted: G W 3.19.0-rc7-next-20150204+ #90 Hardware name: Atmel SAMA5 (Device Tree) Workqueue: events output_poll_execute [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [] (show_stack) from [] (warn_slowpath_common+0x84/0xb0) [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) [] (warn_slowpath_null) from [] (clk_unprepare+0x24/0x2c) [] (clk_unprepare) from [] (atmel_hlcdc_crtc_disable+0xf0/0x114) [] (atmel_hlcdc_crtc_disable) from [] (__drm_helper_disable_unused_functions+0xa4/0xd8) [] (__drm_helper_disable_unused_functions) from [] (drm_helper_disable_unused_functions+0x14/0x20) [] (drm_helper_disable_unused_functions) from [] (drm_fbdev_cma_init+0x78/0xfc) [] (drm_fbdev_cma_init) from [] (atmel_hlcdc_fb_output_poll_changed+0x30/0x40) [] (atmel_hlcdc_fb_output_poll_changed) from [] (output_poll_execute+0x148/0x188) [] (output_poll_execute) from [] (process_one_work+0xfc/0x310) [] (process_one_work) from [] (worker_thread+0x60/0x478) [] (worker_thread) from [] (kthread+0xd4/0xec) [] (kthread) from [] (ret_from_fork+0x14/0x34) ---[ end trace 9500ebf8d7076b61 ]--- Sylvain