linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path and stdout-path
Date: Wed, 11 Feb 2015 12:40:27 +0000	[thread overview]
Message-ID: <20150211124027.GH9154@leverpostej> (raw)
In-Reply-To: <ea777ffbffea442e3bc69fe11183811772a5716e.1423657710.git.michal.simek@xilinx.com>

On Wed, Feb 11, 2015 at 12:29:02PM +0000, Michal Simek wrote:
> parallella - Use reference instead of hardcoded path
>              (linux,stdout-path)
> 
> stdout-path is used by bootloader to identify console.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> U-Boot driver model requires stdout-path.
> ---
>  arch/arm/boot/dts/zynq-parallella.dts | 3 ++-
>  arch/arm/boot/dts/zynq-zc702.dts      | 2 ++
>  arch/arm/boot/dts/zynq-zc706.dts      | 2 ++
>  arch/arm/boot/dts/zynq-zed.dts        | 2 ++
>  arch/arm/boot/dts/zynq-zybo.dts       | 2 ++
>  5 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
> index 6a5f51daa708..45228a427006 100644
> --- a/arch/arm/boot/dts/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/zynq-parallella.dts
> @@ -35,7 +35,8 @@
>  
>  	chosen {
>  		bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait";
> -		linux,stdout-path = "/amba/serial at e0001000";
> +		linux,stdout-path = &uart1;
> +		stdout-path = &uart1;

Given that you added aliases in the last patch, you can use that to
refer to the serial:

	stdout-path - "serial0:115200n8";

With or without the alias you can encode the UART configuration here
too:

	stdout-path = "/amba/serial at e0001000:115200n8"

Which makes the expected configuration explicit without relying on the
Linux-specific bootargs.

Is there any reason to keep linux,stdout-path?

Thanks,
Mark.

  reply	other threads:[~2015-02-11 12:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 12:29 [PATCH 1/2] ARM: dts: zynq: Add missing alias node for zybo and parallella Michal Simek
2015-02-11 12:29 ` [PATCH 2/2] ARM: dts: zynq: Add linux,stdout-path and stdout-path Michal Simek
2015-02-11 12:40   ` Mark Rutland [this message]
2015-02-11 14:25     ` [PATCH 2/2] ARM: dts: zynq: Add linux, stdout-path " Michal Simek
2015-02-11 18:18       ` Andreas Färber
2015-02-12  9:36         ` Michal Simek
     [not found]     ` <54DB663E.4060605@xilinx.com>
2015-02-12  9:38       ` Michal Simek
2015-02-11 17:22 ` [PATCH 1/2] ARM: dts: zynq: Add missing alias node for zybo and parallella Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150211124027.GH9154@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).