linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed
Date: Fri, 13 Feb 2015 10:57:53 +0000	[thread overview]
Message-ID: <20150213105752.GU8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150213103716.GQ14954@e106497-lin.cambridge.arm.com>

On Fri, Feb 13, 2015 at 10:37:16AM +0000, Liviu Dudau wrote:
> On Thu, Feb 12, 2015 at 07:42:33PM +0000, Arnd Bergmann wrote:
> > The vexpress tc2 power management code calls mcpm_loopback, which
> > is only available if ARM_CPU_SUSPEND is enabled, otherwise we
> > get a link error:
> > 
> > arch/arm/mach-vexpress/built-in.o: In function `tc2_pm_init':
> > arch/arm/mach-vexpress/tc2_pm.c:389: undefined reference to `mcpm_loopback'
> 
> Arnd,
> 
> We are having reports of TC2 not booting with MCPM enabled. Lorenzo
> was investigating this but then headed for Linaro Connect this week,
> so we don't have yet a resolution. Can this patch be postponed for
> a later -rc?

Why?

This patch isn't forcing MCPM to be enabled for Versatile Express.

* In order to build tc2_pm.c, MCPM must already be enabled (the
  feature depends on MCPM in the Kconfig already)
* When this feature is enabled, the above link error occurs if
  ARM_CPU_SUSPEND is not also enabled.

So, it is merely fixing the requirement that tc2_pm.c needs the CPU
suspend infrastructure, which in turn has no effect on whether MCPM
is enabled or not.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-02-13 10:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 19:42 [PATCH 00/11] ARM: random randconfig fixes, soc specific Arnd Bergmann
2015-02-12 19:42 ` [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed Arnd Bergmann
2015-02-13  1:31   ` Nicolas Pitre
2015-02-13 10:37   ` Liviu Dudau
2015-02-13 10:57     ` Russell King - ARM Linux [this message]
2015-02-13 11:01       ` Liviu Dudau
2015-02-13 11:16         ` Russell King - ARM Linux
2015-02-13 11:22           ` Liviu Dudau
2015-02-13 23:03             ` Nicolas Pitre
2015-02-13 22:55     ` Nicolas Pitre
2015-02-14  1:34       ` Liviu Dudau
2015-02-14 20:42         ` Lorenzo Pieralisi
2015-02-12 19:42 ` [PATCH 02/11] ARM: sunxi: always select RESET_CONTROLLER Arnd Bergmann
2015-02-13  9:09   ` Maxime Ripard
2015-02-16 20:47     ` Arnd Bergmann
2015-02-12 19:42 ` [PATCH 03/11] ARM: BCM: put back ARCH_MULTI_V7 dependency for mobile Arnd Bergmann
2015-02-12 20:02   ` Florian Fainelli
2015-02-12 20:08     ` arnd at arndb.de
2015-02-12 21:57   ` Florian Fainelli
2015-02-12 22:07     ` Scott Branden
2015-02-12 19:42 ` [PATCH 04/11] ARM: davinci: davinci_cfg_reg cannot be init Arnd Bergmann
2015-02-16 15:37   ` Sekhar Nori
2015-02-12 19:42 ` [PATCH 05/11] ARM: davinci: multi-soc kernels require AUTO_ZRELADDR Arnd Bergmann
2015-02-16 15:50   ` Sekhar Nori
2015-02-12 19:42 ` [PATCH 06/11] ARM: at91: fix pm declarations Arnd Bergmann
2015-02-13  8:37   ` Nicolas Ferre
2015-02-12 19:42 ` [PATCH 07/11] ARM: prima2: do not select SMP_ON_UP Arnd Bergmann
2015-02-13  3:05   ` Barry Song
2015-02-12 19:42 ` [PATCH 08/11] ARM: ixp4xx: fix {in,out}s{bwl} data types Arnd Bergmann
2015-02-16 14:16   ` Krzysztof Hałasa
2015-02-12 19:42 ` [PATCH 09/11] ARM: rockchip: make rockchip_suspend_init conditional Arnd Bergmann
2015-02-13 19:26   ` Heiko Stübner
2015-02-12 19:42 ` [PATCH 10/11] ARM: sti: always enable RESET_CONTROLLER Arnd Bergmann
2015-02-13  7:28   ` Patrice Chotard
2015-02-13  8:09   ` Maxime Coquelin
2015-02-12 19:42 ` [PATCH 11/11] ARM: mvebu: build armada375-smp code conditionally Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150213105752.GU8656@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).